Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed OAI-PMH requests generate an internal server error #9275

Closed
claudiodsf opened this issue Jan 11, 2023 · 5 comments · Fixed by #10205
Closed

Malformed OAI-PMH requests generate an internal server error #9275

claudiodsf opened this issue Jan 11, 2023 · 5 comments · Fixed by #10205
Labels
Feature: Harvesting Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect User Role: API User Makes use of APIs
Milestone
6.2

Comments

@claudiodsf
Copy link
Contributor

claudiodsf commented Jan 11, 2023 •
edited
Loading

What steps does it take to reproduce the issue?

Try a malformed request, like, e.g., without any keyword:

https://demo.dataverse.org/oai

Or with a bad keyword:

https://demo.dataverse.org/oai?key=value

  • When does this issue occur?

Always

  • Which page(s) does it occurs on?

OAI-PMH protocol

  • What happens?

The bad request generates an "Internal Server Error"

  • To whom does it occur (all users, curators, superusers)?

All users

  • What did you expect to happen?

The client should get an XML response with an error message from the OAI-PMH protocol.

This used to work on old version of Dataverse, example:

https://entrepot.recherche.data.gouv.fr/oai

https://entrepot.recherche.data.gouv.fr/oai?key=value

(The installation in the example runs Dataverse 5.3)

Which version of Dataverse are you using?

5.12, 5.12.1

Any related open or closed issues to this bug report?

Screenshots:
@landreev
Copy link
Contributor

Sure, we will fix this.

@poikilotherm
Copy link
Contributor

I am pretty sure this is not an error within the XOAI library - there is a test case for this.

https://github.com/gdcc/xoai/blob/f3310c91334445bd5ac81e265745e80f4c7f7c7b/xoai-data-provider/src/test/java/io/gdcc/xoai/dataprovider/DataProviderTest.java#L58-L64

@pdurbin pdurbin mentioned this issue Jun 2, 2023
Closed
@pdurbin pdurbin added Type: Bug a defect User Role: API User Makes use of APIs labels Oct 9, 2023
@cmbz
Copy link

cmbz commented Dec 19, 2023

2023/12/19: Prioritized during meeting on 2023/12/18. Added to Needs Sizing.

@landreev
Copy link
Contributor

Slightly surprised it's still there...
As Oliver is saying above, this is not in the xoai library, so must be something simple in the oai servlet in the Dataverse code base.
Giving it a very generous 10, just in case.

@landreev landreev added the Size: 10 A percentage of a sprint. 7 hours. label Dec 19, 2023
@pdurbin pdurbin self-assigned this Jan 4, 2024
pdurbin added a commit that referenced this issue Jan 4, 2024
@pdurbin
add docker compose config to get HarvestingServerIT to pass #9275
057d1b9
pdurbin added a commit that referenced this issue Jan 4, 2024
@pdurbin
assert 500 error when invalid query params are passed #9275
37d3d41
@pdurbin pdurbin mentioned this issue Jan 4, 2024
Merged
@pdurbin pdurbin removed their assignment Jan 4, 2024
pdurbin added a commit that referenced this issue Jan 4, 2024
@pdurbin
show errors (in XML) for verb params #9275
27fa154
pdurbin added a commit that referenced this issue Jan 8, 2024
@pdurbin
clean up error handling #9275
88af3d4 
dataProvider.handle(params) allows us to return the correct error.
pdurbin added a commit that referenced this issue Jan 12, 2024
@pdurbin
Update docker-compose-dev.yml better explain presence of settings #9275
d3f3eb9
pdurbin added a commit that referenced this issue Jan 16, 2024
@pdurbin
Merge branch 'develop' into 9275-harvest-invalid-query-params #9275
412c9a1
pdurbin added a commit that referenced this issue Jan 16, 2024
@pdurbin
expect noSetHierarchy rather than noRecordsMatch #9275
30e357b
pdurbin added a commit that referenced this issue Jan 16, 2024
@pdurbin
remove assertion about census not existing (doesn't appear) #9275
95cc8cb
pdurbin added a commit that referenced this issue Jan 16, 2024
@pdurbin
drop "no such set test" #9275
edd6fc8
@pdurbin pdurbin added this to the 6.2 milestone Jan 17, 2024
@pdurbin
Copy link
Member

pdurbin commented Jan 17, 2024

@claudiodsf fixed in this PR:

Thanks for reporting this!

stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
add docker compose config to get HarvestingServerIT to pass #9275
ce6234a
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
assert 500 error when invalid query params are passed #9275
6f3aee4
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
show errors (in XML) for verb params #9275
34196df
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
clean up error handling #9275
3d1f59a 
dataProvider.handle(params) allows us to return the correct error.
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
Update docker-compose-dev.yml better explain presence of settings #9275
51cd1cd
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
expect noSetHierarchy rather than noRecordsMatch #9275
90e4212
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
remove assertion about census not existing (doesn't appear) #9275
ba9e05e
stevenwinship pushed a commit that referenced this issue Jan 22, 2024
@pdurbin @stevenwinship
drop "no such set test" #9275
dddc2ae
@pdurbin pdurbin mentioned this issue Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Harvesting Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect User Role: API User Makes use of APIs
Projects
None yet
Milestone
6.2
Development

Successfully merging a pull request may close this issue.

OAI-PMH error handling: meaningful errors in XML for verb processing IQSS/dataverse
5 participants
@pdurbin @landreev @claudiodsf @poikilotherm @cmbz