Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give contributors guidance on how to write a release note snippet #9264

Closed
pdurbin opened this issue Jan 5, 2023 · 6 comments · Fixed by #10203
Closed

give contributors guidance on how to write a release note snippet #9264

pdurbin opened this issue Jan 5, 2023 · 6 comments · Fixed by #10203
Labels
Feature: Developer Guide good first issue appears at https://github.com/IQSS/dataverse/contribute Hackathon: Low Hanging Fruit hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ Help Wanted: Documentation Mentor: pdurbin
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Jan 5, 2023

Currently, the information is buried here: https://guides.dataverse.org/en/5.12.1/developers/making-releases.html#write-release-notes

We should add something to the "how to make a pull request" docs: https://guides.dataverse.org/en/5.12.1/developers/version-control.html#how-to-make-a-pull-request (this is a bit buried too, by the way).

We might also want to add something here: https://guides.dataverse.org/en/5.12.1/developers/documentation.html#quick-fix

@pdurbin pdurbin added Hackathon: Low Hanging Fruit Feature: Developer Guide Help Wanted: Documentation Mentor: pdurbin hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ good first issue appears at https://github.com/IQSS/dataverse/contribute labels Sep 27, 2023
@pdurbin
Copy link
Member Author

pdurbin commented Sep 27, 2023

@bencomp
Copy link
Contributor

bencomp commented Oct 24, 2023

And if you want to stimulate (or enforce) the addition of release notes, you could use a GitHub workflow to suggest or check for them. I am thinking something like "if PR notes say release notes are needed, then check if a corresponding file exists and respond with 'thank you!'. Else, gently remind the contributor that no release notes were found."

@pdurbin
Copy link
Member Author

pdurbin commented Oct 24, 2023

Sure, maybe a reach goal for this issue. 😄

But just some docs is also fine.

@sbondka
Copy link
Contributor

sbondka commented Dec 20, 2023

Could you please provide me with more information regarding this issue? I have started making changes in the "Commit Your Change to Your New Branch" and "Find or Create a GitHub Issue" sections of the file "https://github.com/IQSS/dataverse/blob/develop/doc/sphinx-guides/source/developers/version-control.rst". Should I also include in the "Make a Pull Request" section the automated process related to adding release notes?

@pdurbin pdurbin changed the title give contributors guidance on how to write a release note give contributors guidance on how to write a release note snippet Jan 5, 2024
@pdurbin
Copy link
Member Author

pdurbin commented Jan 5, 2024

@sbondka yes, that would be a perfect place for it.

However, the process isn't automated. Contributors write snippets and later someone manually combines them.

Please feel free to hit me up on https://chat.dataverse.org with any questions! Thanks for your interest in this!

@pdurbin
Copy link
Member Author

pdurbin commented Jan 5, 2024

Whoops, now I see that you already created this PR:

I'll make some suggestions or edits. Thanks!

pdurbin added a commit to pdurbin/dataverse that referenced this issue Jan 5, 2024
sbondka added a commit to Recherche-Data-Gouv/dataverse that referenced this issue Jan 8, 2024
@pdurbin pdurbin added this to the 6.2 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Developer Guide good first issue appears at https://github.com/IQSS/dataverse/contribute Hackathon: Low Hanging Fruit hacktoberfest It's Hacktoberfest! https://groups.google.com/g/dataverse-community/c/n_Nn_T2yA-w/m/BcoXO4tEAQAJ Help Wanted: Documentation Mentor: pdurbin
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants