Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the OAI code, Step 2 #8842

Open
landreev opened this issue Jul 14, 2022 · 12 comments
Open

Refactor the OAI code, Step 2 #8842

landreev opened this issue Jul 14, 2022 · 12 comments
Assignees
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues Size: 80 A percentage of a sprint. 56 hours.

Comments

@landreev
Copy link
Contributor

This is a followup issue for #8372 (PR #8753).
Once that is merged we can proceed cleaning up and refactoring the remaining old OAI code.
Some of that code predates Dataverse and was copy-and-pasted from the implementation in DVN.
In the process it created in some extra layers of code that duplicate each other, and should probably be significantly simplified. (That is on top of a significant amount of old code that we used to maintain on the Dataverse side, but got rid of in Step. 1 when switching to the new gdcc/xoai library).
Major pieces:

  • Server: the object implementing XOAI "items" (DataverseXoaiItem) acts as a wrapper around the entity class storing the record in the database (OAIRecord). The XOAI items should instead implement both. There's a similar situation with the Set objects.
  • Client: OaiHandler may not be necessary/may be duplicating the functionality provided by the XOAI library; should be possible to further streamline the implementation.

Aside from that, the overall code needs to be cleaned up and modernized.

@poikilotherm
Copy link
Contributor

poikilotherm commented Jul 21, 2022

@landreev
Copy link
Contributor Author

landreev commented Jan 9, 2023

This is a big, elephant-sized issue. We can try and estimate it, but in the spirit of our current process - should we consider splitting it into smaller/manageable chunks instead?

@mreekie
Copy link

mreekie commented Jan 9, 2023

sizing:

  • This needs to be split out into smaller issues.
  • we will take a swipe at this during the discussion of 1.4.1
  • skipping sizing for now.

@landreev
Copy link
Contributor Author

landreev commented Jan 9, 2023

I will make an attempt to create the child issue for the identifiable sub-tasks involved.

@mreekie
Copy link

mreekie commented Jan 23, 2023

sizing:

  • PM added to ordered sizing queue
  • I recommend that we split off a spike from this to capture the work of breaking into child issues which Leonid has proposed

@mreekie mreekie added the Size: Queued PM has called this issue out specifically for sizing label Jan 23, 2023
@mreekie
Copy link

mreekie commented Jan 23, 2023

Sizing:

@mreekie mreekie added pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards labels Mar 20, 2023
@mreekie
Copy link

mreekie commented Apr 19, 2023

Sizing:

  • Leonid will step through issues before monday and create a plan/break off issues

@cmbz
Copy link

cmbz commented Jun 1, 2023

@landreev I'm following up on @mreekie's comment from 19 April.

  • Can you share links to the planned issues he mentions?

@cmbz cmbz added pm.GREI-d-2.4.1 NIH, yr2, aim4, task1: Implement packaging standards based on working group feedback pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues and removed pm.GREI-d-2.4.1 NIH, yr2, aim4, task1: Implement packaging standards based on working group feedback labels Jun 2, 2023
@cmbz
Copy link

cmbz commented Jun 30, 2023

@landreev Following up on @mreekie's comment from 19 April: Could you share links to the issues he mentions related to this issue: #8842?

@cmbz cmbz added this to the 6.1 milestone Sep 25, 2023
@cmbz
Copy link

cmbz commented Sep 25, 2023

2023/09/25: Added to 6.1 milestone as per conversation during prioritization meeting.

@cmbz
Copy link

cmbz commented Oct 23, 2023

2023/10/23: Sized at 80 due to the scope of the work anticipated.

@cmbz cmbz added the Size: 80 A percentage of a sprint. 56 hours. label Oct 23, 2023
@pdurbin pdurbin removed the Size: Queued PM has called this issue out specifically for sizing label Oct 23, 2023
@scolapasta scolapasta modified the milestones: 6.1, 6.2 Oct 26, 2023
@cmbz
Copy link

cmbz commented Mar 12, 2024

2024/03/12
Unfortunately, this issue won't be addressed in 6.2 but I will add it as a 6.3 milestone instead.

@cmbz cmbz removed this from the 6.2 milestone Mar 12, 2024
@cmbz cmbz added this to the 6.3 milestone Mar 12, 2024
@landreev landreev self-assigned this May 22, 2024
@cmbz cmbz removed this from the 6.3 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues Size: 80 A percentage of a sprint. 56 hours.
Projects
Status: SPRINT READY
Development

No branches or pull requests

6 participants