Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle missing "dataverse.publish.not.authorized" #7438

Closed
qqmyers opened this issue Nov 24, 2020 · 3 comments · Fixed by #7620
Closed

Bundle missing "dataverse.publish.not.authorized" #7438

qqmyers opened this issue Nov 24, 2020 · 3 comments · Fixed by #7620

Comments

@qqmyers
Copy link
Member

qqmyers commented Nov 24, 2020

A reference to "dataverse.publish.not.authorized" was added in the DataversePage 6 years ago line 938 but a matching string was not added to Bundle.properties at that time and doesn't appear to exist in the current Bundle.properties.

This was discovered when looking through a log after an update to 5.1.1 around the time the UT Dorkbot was scanning the TDL repository. Although I haven't explored very far, it appears that Dorkbot tries to do things like emulate button clicks without sending the session cookie, hence it can discover things like this that may not occur normally (if you don't have permission, you don't see the button).

@djbrooke
Copy link
Contributor

djbrooke commented Dec 1, 2020

@qqmyers what's your preference here? Should I whip up some text for the bundle and add it, or should we remove the reference from the Dataverse page?

@qqmyers
Copy link
Member Author

qqmyers commented Dec 1, 2020

No preference. It's probably easier to add text and it is possible that there could be some non-Dorkbot way to trigger the problem now or in the future, so perhaps better to have a response ready?

@mheppler
Copy link
Contributor

Looking at the changes that @qqmyers referenced, I found that the original hard coded message text was "Only authenticated users can release a dataverse." That message is already in the bundle as dataverse.release.authenticatedUsersOnly. So I have submitted a PR to point the error msg in DataversePage to that bundle, as opposed to the one that does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants