Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to change file metadata via API if not also changing label or directoryLabel #6962

Closed
pdurbin opened this issue Jun 5, 2020 · 0 comments · Fixed by #6968
Closed

Unable to change file metadata via API if not also changing label or directoryLabel #6962

pdurbin opened this issue Jun 5, 2020 · 0 comments · Fixed by #6968

Comments

@pdurbin
Copy link
Member

pdurbin commented Jun 5, 2020

I'm aware of #6846 but it was opened before pull request #6893 was merged. It was failing with a 500 error.

As of 97e7a60 it's failing with a 400 error and "Filename already exists at data.tsv" which makes me suspicious of pull request #6893. Here's where I added an extra pretty print to see that error:

Screen Shot 2020-06-05 at 3 24 24 PM
@pdurbin pdurbin self-assigned this Jun 5, 2020
pdurbin added a commit that referenced this issue Jun 5, 2020
@pdurbin
quick fix to get test passing in FilesIT #6962
3aca997
@pdurbin pdurbin mentioned this issue Jun 5, 2020
Closed
@pdurbin pdurbin changed the title FilesIT.testForceReplaceAndUpdate failing post merging of pull request #6893 Unable to change file metadata via API if not also changing label or directoryLabel Jun 5, 2020
pdurbin added a commit that referenced this issue Jun 5, 2020
@pdurbin
allow changes to file metadata via API #6962
809643a
@pdurbin pdurbin mentioned this issue Jun 5, 2020
Merged
@pdurbin pdurbin removed their assignment Jun 5, 2020
pdurbin added a commit that referenced this issue Jun 8, 2020
@pdurbin
allow file metadata changes if passing existing path/name #6962
508e95c
pdurbin added a commit that referenced this issue Jun 9, 2020
@pdurbin
allow changes if dir exists and label passed, formatting #6962
9954220
pdurbin added a commit that referenced this issue Jun 9, 2020
@pdurbin
avoid dir1 + file1 == dir + 1file1 (add "/") #6962
e5ec9bc
pdurbin added a commit that referenced this issue Jun 9, 2020
@pdurbin
eliminate code we don't need, handled elsewhere #6962
491caff 
If null, populated by old values anyway.
pdurbin added a commit that referenced this issue Jun 10, 2020
@pdurbin
ensure passing "" as directoryLabel doesn't cause problems #6962
a34d7c1
pdurbin added a commit that referenced this issue Jun 15, 2020
@pdurbin
simply conflict-checking code #6962
2debed2
@pdurbin pdurbin mentioned this issue Jun 26, 2020
Closed
kcondon added a commit that referenced this issue Jul 1, 2020
@kcondon
Merge pull request #6968 from IQSS/6962-bugfix
bc06fe6 
allow changes to file metadata via API #6962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@pdurbin