Settings API broken?

[landreev]

It looks like you can no longer modify an existing setting via the API:

curl -X PUT -d FAKE http://localhost:8080/api/admin/settings/:DoiProvider

throws a 500; the error in the server log:

... org.postgresql.util.PSQLException: ERROR: duplicate key value violates unique constraint "unique_settings"
  Detail: Key (name, (COALESCE(lang, ''::text)))=(:DoiProvider, ) already exists.
Call: INSERT INTO SETTING (CONTENT, LANG, NAME) VALUES (?, ?, ?)
	bind => [3 parameters bound]
Query: InsertObjectQuery([Setting name::DoiProvider value:FAKE])

I am assuming this is the result of merging the PR #6042 - where we made the settings localize-able.

[landreev]

This is the code that has stopped working, in SettingsServiceBean:

public Setting set( String name, String content ) {
        Setting s = new Setting( name, content );
        s = em.merge(s);
        actionLogSvc.log( new ActionLogRecord(ActionLogRecord.ActionType.Setting, "set")
                            .setInfo(name + ": " + content));
        return s;
    }

It's still working for creating a new setting; failing when modifying an existing one. I'm assuming it used to work because the "name" was designated to serve as the @id of the table. Now that the constraint has been removed, EJB tries to create a new entry in the table. But, since there is a database index, unique on the combination of name+value+lang - it ends up throwing the exception above.

If we were to choose to fix this without reverting the original PR, we would simply modify the method above (and any similar methods there) to first look up the setting that the method wants to update, and only create a new one if it does not exist...