Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement discoverability rules for search/browse in 4.0 (permissions) #57

Closed
eaquigley opened this issue Jul 9, 2014 · 6 comments
Closed
Assignees

Comments

@eaquigley
Copy link
Contributor


Author Name: Philip Durbin (@pdurbin)
Original Redmine Issue: 3464, https://redmine.hmdc.harvard.edu/issues/3464

Original Assignee: Philip Durbin


The rules are being finalized here: https://trello.com/c/CkRb3dYl/49-define-search-browse-permissions-discoverability-rules

In previous discussions around Lucene, we started looking at these links to help us implement the rules we want:


Related issue(s): #341, #380
Redmine related issue(s): 3430, 3756, 3795


@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-04-28T20:40:05Z


The main reason we moved this out of beta is that permissions are not fully implemented. For now, we're looking the creator of dataverse or dataset to decide whether or not it should be discoverable before it has been published. See also #3795 which has a lot of permissions-related code.

The main commit where we starting using the Solr JOIN feature is this one:

some discovery rules for search/browse #3464 · 2505cb7 · IQSS/dataverse - 2505cb7

See also http://lucene.472066.n3.nabble.com/document-level-security-filter-solution-for-Solr-td4126992.html#a4127576

@pdurbin
Copy link
Member

pdurbin commented Aug 7, 2014

Some thinking from https://docs.google.com/spreadsheet/ccc?key=0AvqMYwdHFZghdFNpVDNvcnh4cTZ5amFwdkExcDU1Q1E&usp=sharing

Please note that "Anonymous" also covers "logged in but no explicitly granted read or write access".

search-browse-permissions

@eaquigley eaquigley modified the milestones: Beta 5 - Dataverse 4.0, Beta 7 - Dataverse 4.0 Aug 15, 2014
@pdurbin pdurbin modified the milestones: Beta 7 - Dataverse 4.0, Long Term Issues-Dataverse 4.0 Aug 19, 2014
@pdurbin pdurbin modified the milestones: Beta 9 - Dataverse 4.0, Long Term Issues-Dataverse 4.0 Nov 12, 2014
pdurbin added a commit that referenced this issue Nov 21, 2014
- more use of targeted reindexing of permissions
- experimental join is still disabled for now
- general cleanup and refactoring
pdurbin added a commit that referenced this issue Nov 24, 2014
- no more per-group Solr docs
- all perms are a sidecar to each set of docs for each dvobjectid
@pdurbin
Copy link
Member

pdurbin commented Dec 2, 2014

For Beta 9 anyway, we are not inheriting permissions from parent dataverse because permissionRoot was hard-coded to true in fb7e65f

In the Google Spreadsheet I added a new sheet for Beta 2 and will attached a screenshot below to show the expected behavior.

Passing to QA.

v2_beta_9_-_2014-12-01_13 03 18

@pdurbin pdurbin removed their assignment Dec 2, 2014
@kcondon kcondon assigned kcondon and unassigned kcondon Dec 3, 2014
@pdurbin
Copy link
Member

pdurbin commented Dec 3, 2014

Also, "unpublished" can mean "deaccessioned" so in the screenshot below, when it says "yes" for either "draft" or "deaccessioned", this should mean that people with ViewUnpublishedDataset permission should be able to them:

deaccessioning_-google_docs-_2014-12-03_13 53 11

This screenshot comes from https://docs.google.com/document/d/1lFcwjtdGIqqQLYYnwtTI2GZNzmzYlrnMk2omGcXO9oY/edit?usp=sharing

@esotiri
Copy link
Contributor

esotiri commented Dec 3, 2014

Created View unpublished DV and DS role, assigned the role to user and iterated through the list of cases from the google spreadsheet:
Anonymous/Logged In But No Explicit Access > ok
ViewUnpublishedDataverse on self > ok
ViewUnpublishedDataverse on parent > on
ViewUnpublishedDataverse on grandparent > ok
ViewUnpublishedDataset on self > ok
ViewUnpublishedDataset on parent > ok
ViewUnpublishedDataset on grandparent > ok

@esotiri
Copy link
Contributor

esotiri commented Dec 3, 2014

I can't test deaccession part of this ticket because of a 500 error on deaccessioning. Opened a new one to fully test the feature #1209

@esotiri esotiri closed this as completed Dec 3, 2014
janvanmansum pushed a commit to janvanmansum/dataverse that referenced this issue Apr 14, 2021
* First db table and api.

* Final changes for prototype.

* Add integration tests.

* Fix indentation.

* Add prototype of newest changes.

* Add URI and URL objects, and new endpoints.

* Add Apache icons.

* Change tokens to licenses.

* Change URIException to IllegalStateException.
kcondon pushed a commit that referenced this issue Mar 16, 2022
Update from Iqss develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants