Edit the position of files in a directory structure

[TaniaSchlatter]

As part of adding the ability to display file hierarchy at the dataset level (#2249), we want to allow files to be added a directory structure. Completing this work will mean that a user will be able to add a file to a dataset that has files imported from a .zip file or any file, and edit the relative position of files in a dataset.

Anticipated workflow is adding file(s), selecting files from the files table, selecting edit, and editing path(s).

UI impact is exposing the path, and making it editable.

Changes will be visible in a revised view of the directory structure.

[djbrooke]

@mheppler can you add the mockup here? Thank you!

[mheppler]

Previous mockups were in Balsamiq, but I whipped up this mock File Upload pg screenshot quick for this issue.

[djbrooke]

• we should allow this editing through the API as well
• we should have some discussion about whether or not to have leading /
• changes should be recorded as a different version
• we should validate the inputs
• changes here would override changes that were previously made or that we set by uploading a zip
• (Gustavo to add the note about updated zip behavior here)

[scolapasta]

In the context of this issue, we discussed the current zip upload process of unzipping and whether it should add a folder to the path for the zip file. We decided we would leave it as is, i.e. no folder gets added. If you upload a zip with three files at the top level and a second zip with three files at the top level, the resulting dataset will have six files at the top level.

Related: #5576

[sekmiller]

Per discussion we will track editing all file metadata via api in another issue.

[mheppler]

API for file metadata viewing/editing is at Add an API endpoint for File Level metadata #4616.

[mheppler]

Merged develop into the branch 6f87904 in order to take advantage all those glorious, new tooltip icons. :dataverseman:

[kcondon]

Issues found:

1. Validation text indicates \ is allowed but when used as a folder separator character, throws validation error and does not save.
2. Note to retest after Leonid's zip cleaning logic is added:
   If upload a zip file containing at least one invalid char in path, it fails upload for all with error in UI: The files could not be updated, server log errors:
   [2019-03-22T15:41:56.918-0400] [glassfish 4.1] [INFO] [] [edu.harvard.iq.dataverse.DatasetVersion] [tid: _ThreadID=54 ThreadName=jk-connector(5)] [timeMillis: 1553283716918] [levelValue: 800] [[
   Constraint violation found in FileMetadata. Directory Name cannot contain invalid characters. Valid characters are a-Z, 0-9, '', '-', '.', '', '/' and ' ' (white space). The invalid value is "testzip/%3".]]
   Caused by: java.lang.ClassCastException: edu.harvard.iq.dataverse.FileMetadata cannot be cast to edu.harvard.iq.dataverse.DatasetField
   at edu.harvard.iq.dataverse.engine.command.impl.AbstractDatasetCommand.lambda$validateOrDie$0(AbstractDatasetCommand.java:104)

[landreev]

Zip uploads: folder names are now preemptively sanitized; all the invalid characters are removed. I discussed this approach with @scolapasta earlier today and we are going to review and finalize it on Monday.

[pdurbin]

A couple of updates from standup:

• Updating the directory structure is now possible from the native API "add" and "replace" endpoint because we merged pull request Set directoryLabel (File Path) via API #5678 into the branch under test for this issue. An update to the API Guide was included.
• I haven't been following very closely the naming convention we are converging on for Flyway scripts but I pushed b2f04e4 to the branch to attempt to document it. This could use some review.

[landreev]

Added doc. info (to the guide and the release notes), as discussed yesterday.