-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Custom Homepage - ROUND TWO #5445
Comments
Related to the "Activity download count being off" to-do list item: #4970 |
For the "Activity" download counts problem, a short-term fix could be to just remove that section of the html until we get the metrics to line up in a future release |
Should Search input watermark dataset count be 27.4k (# of datasets added?) or 81.2k (total number including harvested)? I'd vote for the latter |
There's some more feedback coming from @mercecrosas for this issue. @TaniaSchlatter will add it tomorrow morning. |
@scolapasta Search input watermark dataset count should be @ 81.2k – total number including harvested. |
Wanted to record this Stack Overflow resource for new column CSS properties used in the subject count and recent dataset sections. |
Regarding the harvested datasets: We can discuss changing this arrangement separately. But for the purposes of this issue, we should simply go ahead and change the dataset-counting queries to work based on this definition, that all the harvested datasets should be counted as published. So instead of doing |
@landreev Thanks for investigating this! I'll make the change :) |
We will try to add this again later. Is it not actually required.
I've run into more problems that I thought trying to get all the file/dataset queries to work dynamically for harvested/local. I removed the dataLocation option from all files queries (as we don't use them in homepage anyways) and from dataset/bySubject . The harvest/local/all queryParam for the other dataset queries seems to work well. After removing this from dataset/bySubject I realized that it was a hard requirement for homepage to get all the results. Talking with @landreev earlier, we agreed that the base query that we had used for datasets/files is a bit confusing and should be rewritten, but I had hoped to avoid doing that as part of the homepage story. We may be able to sidestep this issue somewhat by writing a different/simpler query that gets the subject counts without caring about the timestamp, and having that return harvest/local. But it'll make the metrics api a bit more confusing and is still work. I'm out tomorrow and will be unable to work on this. Feel free to revert my last two commits if needed to work on the bySubject query. |
btw, the approach I was trying was to update this section of bySubject/toMonth:
removing it to be how the basic |
I can definitely help figuring out better queries there. And yes, it looks like the only harvested datasets that have numeric version numbers are the ones harvested from other Dataverses. The ones harvested from generic OAI archives and such don't. Whether this is a problem necessarily - we need to find out; that fragment in the query:
may simply become a "0" when the version numbers are missing; and it would still uniquely identify the dataset, in combination with the dataset id. |
(and yes, the bySubjectToMonth should be the same query as bySubject - but with the time argument added...) |
@landreev thats correct the totals look to be working correct now. Thanks for looking into this. |
so yeah, these lines:
or
both result in empty strings when versionnumber and/or minorversionnumber are null. so count(*) works - it just counts lines, regardless of the content. But "where ... in ..." using this expression only finds the versions with the version numbers present. (I'm working on a simpler query) |
… harvested datasets (or both). (ref #5445)
OK, I haven't really made it simpler per se; I'm still relying on the "max(datasetversion.versionnumber + (.1 * datasetversion.minorversionnumber))" gimmick in order to select the latest released version, for the local datasets (haven't been able to think of a simpler/cleaner query). (I've only modified the datasets/bySubjectToMonth query; if any other similar queries in there need to be able to select either local, or harvested, or both - they need be similarly modified) |
Misc HTML + CSS + layout improvements
...
...
...
...
Javascript fixes
Other customization fixes
Homepage template fixes
Additional curation efforts
Related GitHub Issues
Updated Activity section
Misc notes...
The text was updated successfully, but these errors were encountered: