-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as a developer, I'd like the docker-aio plumbing to work. #5374
Comments
Don't throw stones on me, but maybe, just maybe, instead of fixing this it might be an idea to switch to Arquillian for IT tests, once my Docker work is done. Adding a ref to this here: #5068 |
@poikilotherm are you using Arquillian in PeerPub? I don't see it in the pom at https://github.com/peerpub/peerpub . Either way switching from REST Assured to Arquillian is out of scope for this issue @pameyer opened but it certainly doesn't hurt to mention the idea! 😄 |
@poikilotherm If |
No, the project wasn't as far and not as complex as Dataverse is. You integrate way more stuff than PeerPub was ever thought to be using... 😉
Don't get me wrong - you still need test cases e. g. with REST Assured! Arquillian is just about automation and control of 'em. |
From some investigation with the normal installer in docker-aio/docker-dcm, it appears that this may be related to either docker oddness or something looking for an interactive shell in the installation script. |
I finally got around to trying this (on 5a24bc8 on "develop") and I had a similarly bad time. The output of
... but the errors started with publishing datasets? Here:
By the end Glassfish isn't running. I'm not sure why this would be related to datasets not publishing. Maybe it isn't. Anyway, I tried starting Glassfish like this:
... then I went to http://localhost:8084 but Glassfish wasn't up like I expected. So I tried to list the running applications but Glassfish was down again already:
So yeah, this is pretty broken, which is unfortunate because we learn more heavily that we should on @pameyer using all this great docker-aio code he wrote to catch all kinds of bug before pull requests get merged. |
Did a little more investigation; currently leaning towards a change in TTY behavior between centos 7.6 and 7.5. |
This is related to IQSS/dataverse#5374. If this blows up, we'll return to 7.5.
Some more info at #5662 (comment) |
From process of elimination, it appears that the external setupIT -> install -> glassfish-setup.sh is where glassfish ends up not running. glassfish-setup.sh runs to completion though. At this point, I'm suspecting something related to the change from |
Current thinking is that the TTY relatedness was the right track, but not due to any centos related changes. #5294 changed an |
I tried the updated readme in pull request #5699 (the two commands at the top) and once again I'm able to use docker-aio to run the API test suite. Thank you, @pameyer ! I'll note that the test suite failed with testMakeDataCountGetMetric failure reported elsewhere and in #5686 (comment) I explained the |
I just created #5702 to track this. As I've said elsewhere I am unable to run the full API test suite against Glassfish running on my Mac laptop because the tests crash Glassfish. 😞 |
This is related to IQSS/dataverse#5374. If this blows up, we'll return to 7.5.
This is related to IQSS/dataverse#5374. If this blows up, we'll return to 7.5.
This is related to IQSS/dataverse#5374. If this blows up, we'll return to 7.5.
At some point,
conf/docker-aio/prep_it.bash
broke and no longer results in a running dataverse instance for running ITs on. Starting glassfish in the container afterprep_it.bash
does result in a working configuration.This issue is more for future reference, in the event anyone else runs into it. Shouldn't be a big fix, not likely to dig into it in the immediate future.
The text was updated successfully, but these errors were encountered: