-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - PrimeFaces 6.2 Upgrade #4220
Comments
Also consider other UI libraries and themes to avoid the PrimeFaces vs Bootstrap conflicts. BootsFaces PrimeFaces Avalon |
Accessibility issues with the |
The release date for 6.2 is now early February. A release candidate is available @ https://www.primefaces.org/primefaces-6-2-rc1-released-california/ |
Dev investigated this update in Spike: investigate upgrading to Primefaces 6.1.1 #3883 |
PrimeFaces 6.2 was released in Feb 2018 and in addition to including the latest and greatest jQuery, the new feature that caught my eye related to page load performance improvements!
|
PrimeFaces has provided this Migration Guide in their GitHub wiki, which outlines "changes that may cause backward compatibility issues in your applications". |
See my comment regarding jQuery libraries in issue UI - Bootstrap 4 Upgrade #4219. |
After reviewing the Migration Guide from PrimeFaces, there doesn't seem to be a whole lot too major. The biggest change with the most impact seems to be the deprecated p:component, which returned 32 matches in 7 files.
I will continue to get as much of this migration tackled as I can, but will recruit developers for some of the heavy lifting if it looks a little out of my wheelhouse. Stay tuned, PrimeFaces fans! |
For the deprecated
|
UPDATE 6/28 by @mheppler - reverted these changes 98b2431 For the deprecated autoUpdate=true, changes have been made to the following:
|
OK, I have combed over the Migration Guide and picked off the low hanging One change that caught my attention in the Migration Guide, but I wasn't sure how to find in the code was this bullet from the 5.3 to 6.0 changes.
If anyone has any thoughts on this one, let me know. If it relates to performance improvements, it could be worth investigating as part of Dataset Files DataTable - Paginator, Selection, Download, Counter #4656 I am going to pass the upgrade baton from here. Earlier I had talked to @matthew-a-dunlap about having a go at what he might find. There are some issues referenced in comments above that I am going to check to see if the upgrade resolved or not. |
In my comments above, I had referenced changes in PrimeFaces 6 related to the Re: Re: PrimeFaces generated checkboxes #2634 -- it appears that there have been improvements to the checkboxes which added the I will add a comment to update both of those issues, as a reference for when we pick those issues for development. Without any other changes to be made related to the upgrade, I am moving this to Code Review. |
I looked around dataverse with PrimeFaces 6.2 and did not see any issues at all. Prov/Publish/Thumbnails/etc seem to work correctly. Looking back over my old notes I hadn't seen much with my spike upgrade either. I think at this point we should move on to QA. |
While looking at this branch, I happened to find a mysterious bug that I can't quite nail down. In the
Could not replicate this bug on demo or locally on the |
@mheppler The cause of this seems to be related to the deprecation of autoUpdate as an attribute for fragments (and other components), and our switch to using the p:autoUpdate tag. It looks like we followed the PrimeFaces upgrade guide correctly yet the update does not take place. If I switch back to the old autoUpdate format the page updates correctly. There is an old comment on that page about buggy autoUpdate behaviour. Looks like in the past we had to create a dummy component to get the update to work.
I removed this dummy ui:repeat and the deprecated autoUpdate still works, but the newer <p:autoUpdate /> still does not. |
I found one forum post with someone experiencing a similar issue, but no resolution: https://forum.primefaces.org/viewtopic.php?f=3&t=55471. |
I tried checking to see if any of our autoUpdate'd components work, but I think that only the one for metadataFragment.xhtml for Compound Fields is needed. The one in the same file for Primitive Fields does not seem to matter with our stock metadata (those primitives can't be +/-). The last one in themesAndWidgetsFragment.xhml doesn't seem to be needed for any of the interactions. |
Reverted |
@mheppler I accidentally stumbled across this topic. If you have problems with p:autoUpdate, which worked before with autoUpdate=true, please create a issue on our PrimeFaces side and provide a forked primefaces-test project, which shows the bug. |
@tandraschko hi, @mheppler is on vacation. Thanks for reaching out. We're aware that |
It looks like you had the p:autoUpdate in the wrong spot. It needs to go inside the p:fragment like... <p:fragment>
<p:autoUpdate/>
</p:fragement> |
@melloware thanks, over at https://gitter.im/primefaces/primefaces?at=5b571f6ee06d7e74099c0909 @tandraschko also suggested that we could add a jsf:id to the div. I let @sekmiller know. |
Thanks for the reply @melloware, this is the actual commit where we reverted the tag 98b2431 |
OK that is strange then that you were having a side effect because from looking at that commit they should be equivalent. You can try the JSF:ID to the DIV but I feel like there is some other underlying issue. If you definitely think it is a defect create a simple reproducible example using our Test project... https://github.com/primefaces/primefaces-test Its a stripped down project that you can do "mvn clean jetty:run" and hit it at localhost:8080 to create the minimum reproducible example. |
Upgrade our Primefaces library from v5.3 to v6.1. Read more here: https://www.primefaces.org/documentation/
Primefaces 6.0 has been out for over a year and a half. They provide improved "accessibility of the components for 508 compliance regarding keyboard and screen reader support." 6.1 has been out for 6 months, and also boasts "major accessibility enhancements" as well as "various new features" for the DataTable component. 6.2 is planned for the end of 2017.
The text was updated successfully, but these errors were encountered: