Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Dataverse brand from email verify subject #3941

Closed
bsilverstein95 opened this issue Jun 21, 2017 · 3 comments
Closed

Missing Dataverse brand from email verify subject #3941

bsilverstein95 opened this issue Jun 21, 2017 · 3 comments
Assignees
Labels
Type: Bug a defect

Comments

@bsilverstein95
Copy link
Contributor

With the rollout of root dataverse branding and modifications to Bundle.properties to include dataverse names in outgoing mail, my old friend ConfirmEmail once again needs some patching.

Opening this issue to separate it from #3407 which @pdurbin noted this week ties into a separate bug in the workflow of converting a builtin user account to shibboleth-based. I've already made headway with adjusting ConfirmEmailServiceBean.java to appropriately add the root dataverse name, e.g. "LibraScholar: Verify your email address" rather than "{0}: Verify your email address"

The fix for this (in lieu of fixing #3407 as well) should be slated for 4.7's release.

@bsilverstein95
Copy link
Contributor Author

For reference, note the {0} in this email's subject line. (Ignore the other issue wherein it's also missing a message body as per #3407 )

brokenemail

@pdurbin
Copy link
Member

pdurbin commented Jun 21, 2017

@bsilverstein95 and I just made pull request #3945 and moved it to Code Review at https://waffle.io/IQSS/dataverse

@djbrooke djbrooke assigned sekmiller and unassigned bsilverstein95 Jun 21, 2017
@sekmiller sekmiller removed their assignment Jun 21, 2017
@kcondon kcondon self-assigned this Jun 21, 2017
@kcondon
Copy link
Contributor

kcondon commented Jun 21, 2017

Works, thanks!

kcondon added a commit that referenced this issue Jun 21, 2017
add installation brand name to subject of verify email message #3941
@kcondon kcondon closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

No branches or pull requests

4 participants