Add a RestAssured test for a Tabular file ingest #3562
Milestone
Comments
|
I'm also getting an OptimisticLockException if I remove a one second "sleep" from test_006_ReplaceFileGoodTabular in FilesIT. I'm on 94494b9 on the 2290-file-replace branch. |
|
I believe I've fixed this in 28b690a. Passing to Code Review in https://waffle.io/IQSS/dataverse |
|
I'll review this as well, since @pdurbin and I talked about this briefly earlier; so I know what this is about and what's going on there. |
landreev
changed the title
|
(this is another issue being reviewed that has no PR of its own; will be attached to the PR 3579, for #2290) The code looks great. I have changed the title of the issue. The original title specifically mentioned the symptom, the OptimisticLockException, that was observed when the Tabular ingest test was added to FilesIT. But the reason it was happening was the very nature of tabular ingest - it modifies the datafile further, in the background, after the main ingest is done. So the copy of the DataFile object still held by the code in the test class was legitimately stale. So Phil solved this by refreshing the object via EJB. The QA for this issue would be to confirm that the restassured test is now working. I'm parking the issue in the QA column. But please note that it will be ready to test only when the parent #2290 is ready for QA. |
|
As of 7a11e9c I'm still getting errors. I'm getting a 500 error (OptimisticLockException per the stacktrace below) rather than an 200. This is line 473 in FilesIT.java, the |
pdurbin
added a commit
that referenced
this issue
Jan 26, 2017
|
Ok, now the PublishDatasetCommand checks to see if the dataset is locked due to ingest: 5fc191b |
|
The tests have been added to a new Rest Assured class called "FilesIT". Here's the complete list of tests classes I expect to pass for pull request #3579:
I'll be updating https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/configure to include FilesIT after pull request #3579 is merged. |
|
Since this is not really part of the feature set but more of a test battery that Phil has been running, I'm marking this as tested since Phil is the main producer/consumer of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of 1c6c6d9 on 2290-file-replace on https://dev1.dataverse.org I was seeing an OptimisticLockException when running the "test_006_ReplaceFileGood" test in FilesIT. I executed this to
mvn test -Dtest=FilesIT. I'm not sure why and it seems intermittent. I can't reproduce it reliably but I did capture a stacktrace (below). If nothing else, this issue should be a reminder to test the new FilesIT test to make sure it passes. After merging the 2290-file-replace branch for #2290, FilesIT should be added to the list of automated tests executed by the "phoenix" server. The list is maintained at https://build.hmdc.harvard.edu:8443/job/phoenix.dataverse.org-apitest-develop/ .The text was updated successfully, but these errors were encountered: