Email Verification: 2 issues; refresh un-verifies, verify email button should always be available.

[kcondon]

Users are starting to use this feature and one reported an issue where they had confirmed their email but the account page said not verified and they did not know what to do, see RT 242896

I found a couple things that may impact this:

1. If I'm on the account info page where there is a verify email button, I press it and then after clicking the confirmation button I refresh that page, it asks to resubmit the form and then it "unverifies" me and sends another email.
2. It seems the verify email button does not appear until after the initial confirmation email timeout, default 24hrs. In cases where there is an issue, like this, it may be useful to always display the button.

[pdurbin]

I just noticed this bug at #3405 (comment)

[bsilverstein95]

Assigning this issue to myself, will work to recreate both of these and go from there. May need to consult the team regarding best practice with changing the Verify Email button's behavior (keeping it visible after confirmation vs having it disappear).

[mheppler]

Proposed solution:

• Always show "Verify Email" button on Account pg
• User clicks button, backend logic...
  • checks for and clears expired tokens
  • checks for active tokens
  • if none, send email with new token
  • if active token found, triggers confirmation popup telling them to check their email

[chewsw]

May I check if there are any updates on the missing email verification button? I've encountered cases where the email verification button do not appear even after the 24 hours deadline has passed.

[pdurbin]

@chewsw hi, no one is working on this bug. If someone out there in the community would like to work on it, I'm happy to point out where in the code to start looking.

[djbrooke]

I'd like to take another pass at this as part of a sprint. I was just getting back to things on Sept 8th when we discussed above (thanks @TaniaSchlatter and @pdurbin) and I asked for it to be moved back to Needs Discussion, but reviewing this again I think we can talk through the remaining issues after picking this up. My goal with this issue is to fix the verification system so that users can reliably put their accounts into a "verified" status, not make any changes to the privileges of verified/non-verified users. That can come next.

[sekmiller]

UI change for review. Part of the solution to this bug was to always display the "Verify Email" button while the user's email is unverified. If the user clicks the button while there is an active token this popup is rendered:

[sekmiller]

For reference. this is the existing success message when the user clicks "Verify Email" when there is no active token:

[mheppler]

Added responsive layout clean up to the fix the overlapping of the email address and verified status label, as reported in #4484. If the containing width is too small, the button and/or status label will wrap to another line. (See screenshot.)