-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Guides have broken github icons in the footer. #3388
Comments
Possibly a symptom related to issue #3181. Will investigate locally. |
…in the guides footer. Resized image file (512px) to be smaller (96px). [ref #3388]
Fixed URL ref to githubicon.png which was displaying as a broken img in the guides footer. Resized image file (512px) to be smaller (96px). Code checked into the 3181-guides-build-warning branch. |
With the direction of @pdurbin, fudged date to test copyright locally. |
Still broken as of 9f93e7b on the homepage for the docs at least. |
I'm proposing a fix in 74d6846 (pull request #3394) that uses an absolute rather than relative path. It relies on the fact that we create a symlink called "latest". That is to say the GitHub icon is at http://guides.dataverse.org/en/latest/_static/images/githubicon.png . Passing to QA. |
use "latest" in path to github icon #3388
All guides in documentation have broken github icons in the footer:
This has happened before, was working in 4.4, broken in 4.5, must use browser like Chrome to see broken image, FF hides it.
The text was updated successfully, but these errors were encountered: