Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Guides have broken github icons in the footer. #3388

Closed
kcondon opened this issue Sep 28, 2016 · 7 comments
Closed

Documentation: Guides have broken github icons in the footer. #3388

kcondon opened this issue Sep 28, 2016 · 7 comments
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Sep 28, 2016

All guides in documentation have broken github icons in the footer:
This has happened before, was working in 4.4, broken in 4.5, must use browser like Chrome to see broken image, FF hides it.

@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev Type: Bug a defect labels Sep 28, 2016
@kcondon kcondon added this to the 4.5.1 - IP Groups fixes milestone Sep 28, 2016
@mheppler
Copy link
Contributor

Possibly a symptom related to issue #3181. Will investigate locally.

mheppler added a commit that referenced this issue Sep 28, 2016
…in the guides footer. Resized image file (512px) to be smaller (96px). [ref #3388]
@mheppler
Copy link
Contributor

Fixed URL ref to githubicon.png which was displaying as a broken img in the guides footer. Resized image file (512px) to be smaller (96px).

Code checked into the 3181-guides-build-warning branch.

@mheppler
Copy link
Contributor

mheppler commented Sep 29, 2016

Made copyright year in guides footer dynamic. d8f1b98

Related to #2905

@kcondon
Copy link
Contributor Author

kcondon commented Sep 29, 2016

The icons are fixed but cannot test the footer date since I cannot adjust the system date on the build machine @mheppler @pdurbin please test on your dev boxes thanks.

@mheppler
Copy link
Contributor

With the direction of @pdurbin, fudged date to test copyright locally.

screen shot 2020-09-29 at 4 35 10 pm

@kcondon kcondon closed this as completed Sep 29, 2016
kcondon added a commit that referenced this issue Sep 29, 2016
@pdurbin pdurbin reopened this Sep 30, 2016
@pdurbin
Copy link
Member

pdurbin commented Sep 30, 2016

Still broken as of 9f93e7b on the homepage for the docs at least.

@pdurbin
Copy link
Member

pdurbin commented Sep 30, 2016

I'm proposing a fix in 74d6846 (pull request #3394) that uses an absolute rather than relative path. It relies on the fact that we create a symlink called "latest". That is to say the GitHub icon is at http://guides.dataverse.org/en/latest/_static/images/githubicon.png . Passing to QA.

@pdurbin pdurbin assigned kcondon and unassigned pdurbin Sep 30, 2016
kcondon added a commit that referenced this issue Sep 30, 2016
use "latest" in path to github icon #3388
@kcondon kcondon closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

3 participants