Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload: Make upload limit text dynamic based on setting #3071

Closed
kcondon opened this issue Apr 11, 2016 · 7 comments
Closed

File Upload: Make upload limit text dynamic based on setting #3071

kcondon opened this issue Apr 11, 2016 · 7 comments
Assignees
Labels
Feature: File Upload & Handling Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@kcondon
Copy link
Contributor

kcondon commented Apr 11, 2016

Our User Guide indicates
The file upload size limit can be found in the text above where files are uploaded in the application but this information is currently static. It should be made dynamic to read the :MaxFileUploadSizeInBytes value in the setting table.

@kcondon kcondon added Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev Feature: File Upload & Handling labels Apr 11, 2016
@kcondon kcondon added this to the 4.4 milestone Apr 11, 2016
@scolapasta scolapasta assigned sekmiller and unassigned scolapasta May 18, 2016
@pdurbin
Copy link
Member

pdurbin commented May 19, 2016

This is hardcoded in src/main/java/Bundle.properties as "file.selectToAdd.tip=File upload limit is 2GB per file..."

@sekmiller
Copy link
Contributor

@kcondon, @eaquigley
When we have a value for MaxFileUploadSizeInBytes we can plug it into the {0} below:
File upload limit is {0} per file. For more information about supported file formats, please refer to the...

Alternate text for when the MaxFileUploadSizeInBytes is not set?
File upload limit is not explicitly set. For more information about supported file formats, please refer to the...

@eaquigley
Copy link
Contributor

@sekmiller @kcondon I would just have the first sentence not render if there is no set file upload limit.

@sekmiller
Copy link
Contributor

Fixed and checked into https://github.com/IQSS/dataverse/tree/3049-accout-notification branch

@kcondon
Copy link
Contributor Author

kcondon commented May 25, 2016

@sekmiller This works but also needs to go on the create dataset page.

@sekmiller
Copy link
Contributor

Dynamic File size is now gotten directly from System Config. Fix is checked into the branch.

@kcondon
Copy link
Contributor Author

kcondon commented May 26, 2016

OK, works, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants