-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index: dataset and file object cards are not shown when role assigned to explicit groups, works with shib groups #3055
Comments
Potential fix but need to make this
All this would go after calling @michbarsinai I'm wondering if we can have a |
@pdurbin If you pass groupService.groupsFor(au, null) you get all groups assigned to the authenticated user. I used the method that way for shib/ip groups. |
We could, but note that ExplicitGroups are defined in a context of a Dataverse. So you would not get ALL the groups.
|
But it would work for shib/ip groups since they are not in the context of a dv? |
Shib should be there. IP groups won't, since they are determined by the IP address of the DataverseQuery.
|
@michbarsinai @sekmiller @scolapasta I implemented a fix in pull request #3062. Code review is very welcome! I'm passing this issue to QA. |
This works now, closing. |
Pull request #3062 now has merge conflicts. Reopening this issue and giving to @scolapasta for prioritization. |
Conflicts: src/main/java/edu/harvard/iq/dataverse/RoleAssigneeServiceBean.java Here are the changes I had to make: - Make RoleAssigneeServiceBean.getUserExplicitGroups public. - Stop using old getUserGroups name. Also, SearchIT better reflects reality in terms of which tests can run successfully at this time.
To be clear, the fix is in pull request #3062 which is the 3055-get-more-groups branch. |
add groupsFor(AuthenticatedUser au) method #3055
Affects explicit groups, works with shib groups:
Update:
Also assigning role to a group directly to an unpublished dataset does not show the dataset card at all.
Granting access to restricted file also does not work with an explicit group, works in my data.
This issue exists in v4.3.
@pdurbin Any chance you can take a quick look to see whether it is a simple fix or something requiring more thought?
The text was updated successfully, but these errors were encountered: