Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse Pg -- Broken Save Functionality, Layout Issue Search-Include Ignoring "Edit" Mode #2775

Closed
mheppler opened this issue Nov 25, 2015 · 5 comments
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@mheppler
Copy link
Contributor

New to 4.2.3's technology branch is a layout issue on the dataverse pg, where the search-include -- with it's search box, facets and results cards -- is being displayed on the edit General Information view of the dataverse pg, just below the Save Changes and Cancel buttons.

In addition to the layout issue, it appears that the Cancel button is broken, doing nothing when clicked, and the Save Changes button, although it brings you back to the "infoMode" view of the dataverse pg, doesn't actually save anything.

@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: High Type: Bug a defect labels Nov 25, 2015
@mheppler mheppler added this to the 4.2.3 milestone Nov 25, 2015
@mheppler mheppler changed the title Dataverse Pg -- Layout Issue, Ignoring "Edit" Mode Dataverse Pg -- Broken Save Functionality, Layout Issue Search-Include Ignoring "Edit" Mode Nov 25, 2015
@mheppler
Copy link
Contributor Author

Related to #2757

@sekmiller
Copy link
Contributor

This was tripping up because the scroll to in the event of error had improper syntax in the PF5 world

<f:ajax onerror="window.scrollTo(0, 0)" />

@sekmiller sekmiller assigned kcondon and unassigned sekmiller Dec 1, 2015
@kcondon
Copy link
Contributor

kcondon commented Dec 1, 2015

When I reported #2757, I tried editing and cancelling and it seemed to work for me for the main general info fields but not for the metadata blocks. This is still the case.

This is still not working for the metadata blocks view fields. This ticket seems to be a duplicate of #2757 based on my testing.

@mheppler
Copy link
Contributor Author

mheppler commented Dec 1, 2015

@kcondon -- this ticket was specifically opened because of the layout issue in the edit view of the dataverse pg, which is not mentioned in your original ticket. I added the save being broken to the ticket when I tried to get as detailed an explanation of what happening as possible. This resulted in some duplication apparently.

@kcondon
Copy link
Contributor

kcondon commented Dec 1, 2015

OK:

  1. not seeing search box in edit mode. Good.
  2. save/ cancel works for general edit but fails for metadata block view state. Less good.

I'm closing this ticket and will open a separate ticket for the issue in #2.

Closing.

@kcondon kcondon closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

3 participants