Assign Role Pop Up: File Downloader Assignment Confirmation

[eaquigley]

Assign Role pop up: If someone is assigning file downloader role at the dataverse or dataset level, when they click Save Changes, we need to add a pop up that says, “Assigning file downloader role means the user(s) will be given access to all restricted and unrestricted files for all versions of this dataset.”

Note: Do we need a confirmation for other roles?

[mheppler]

Added static placeholder confirmFileDownloader dialog as a confirmation popup to the roles-assign pg for the dataverse/dataset permissions pg.

[mheppler]

Reviewed with @scolapasta @sekmiller @eaquigley -- proposed to change the confirmation popup to additional help/info text in the Assign Role popup.

The original proposed text was:

“Assigning file downloader role means the user(s) will be given access to all restricted and unrestricted files for all versions of this dataset.”

Which can be generically/dynamically changed to:

“Assigning {role name} role means the user(s) will have {role name} role applied to all {object types} within this {object type}.”

[mheppler]

Added warning/info text to Assign Role popup on Dataverse/Dataset Permissions pg.

Passing to @sekmiller to wire up the object types.

[sekmiller]

Fix applied and checked into branch

[kcondon]

This fix is in branch 2572 according to Stephen: It's in the permissions branch 2572
It has not yet be made into a pull request.

[kcondon]

Leaving in QA but removing my name until I receive pull request.

[kcondon]

Variable text is in place but when assigning roles at the dataset level, the text in some cases also says, Dataverses: Assigning the Member role means the user(s) will have the Member role applied to all Dataverses, Datasets, Files within this Dataset.

Since this at the dataset level, dataverses should not be in the message. Not all roles includes dataverses, why?

Roles including dataverses at dataset level: admin, curator, member

[sekmiller]

Fixed the logic that displays the types of objects that a user will be granted permission on.

[kcondon]

The issue I previously reported was fixed but found one more, sorry!
When you assign roles at a dataverse, any sub dataverses do not automatically get those perms since currently dataverses are "permission root" meaning they define their own perms and do not inherit.
So, messages at dv level should also not include dataverses.

[kcondon]

Works, closing.