-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code style/Ops: use Logger.log instead of System.out.print[ln] #2575
Milestone
Comments
bencomp
added a commit
to bencomp/dataverse
that referenced
this issue
Sep 24, 2015
Closed
mheppler
added
Component: Documentation
Component: Code Infrastructure
formerly "Feature: Code Infrastructure"
labels
Jan 28, 2016
pdurbin
removed
Component: Code Infrastructure
formerly "Feature: Code Infrastructure"
Status: Triaged
labels
Jun 13, 2017
pdurbin
added a commit
that referenced
this issue
Jun 20, 2017
This was referenced Jun 20, 2017
Merged
Nice work on the style guide, @pdurbin! Note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up on #775.
java.util.logging.Logger
provides a consistent way of sending log messages to the centralised log, including a level indicating the importance of the message.System.out.print
andSystem.out.println
messages do end up in the log, but without a source and all atLevel.INFO
.It helps tremendously to operate a Dataverse installation if log messages are informative. That, to us, means that every message has at least a source and the right importance level. Currently there are nearly 200 uses of
System.out
in the codebase, although a lot are commented out and some are even "hidden" inside something like:The style guide has more tips for logging, like using the warning (or severe) level when an exception is caught.
The text was updated successfully, but these errors were encountered: