Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZID Service Bean: Modify Logging To include Warnings when processes fail #2277

Closed
sekmiller opened this issue Jun 17, 2015 · 5 comments
Closed

EZID Service Bean: Modify Logging To include Warnings when processes fail #2277

sekmiller opened this issue Jun 17, 2015 · 5 comments
Assignees
@sekmiller

Comments

@sekmiller
Copy link
Contributor

When connections to EZID server or create/modify identifier fail, we are only putting INFO into the log not WARNING. We should make them warnings
@bencomp
Copy link
Contributor

bencomp commented Jun 17, 2015

Agreed :)

@scolapasta scolapasta modified the milestone: In Review Jun 26, 2015
@bencomp
Copy link
Contributor

bencomp commented Jul 6, 2015

(This is one of the guidelines for a nicer code style in #775.)

@bencomp
Copy link
Contributor

bencomp commented Jul 14, 2015

Actually, I am thinking that when logging into the EZID service fails, this should be logged as SEVERE. What happens if login fails? Will DOIs not be registered? What if the login failure is caused by bad configuration?

bencomp added a commit to bencomp/dataverse that referenced this issue Jul 14, 2015
@bencomp
Improve log messages in DOIEZIDServiceBean IQSS#2277 IQSS#775
0119f16 
Change INFO messages to WARNINGs when something went wrong;

use log message templates instead of concatenation, and the Throwable variant when
a Throwable is passed.

Improve formatting, add some javadoc.
@bencomp
Copy link
Contributor

bencomp commented Jul 14, 2015

Even though I said SEVERE may be better, I gave WARNING a shot in bencomp@0119f16. Since some log calls include Throwables, I changed the call to use the Throwable-accepting variant.

@pdurbin
Copy link
Member

pdurbin commented Jul 15, 2015

I spoke with @sekmiller about this and he said this issue has become a lower priority for us (post 4.1 for sure) because EZID is doing more now to insulate us from DataCite failures. Or something! He said he's check out the commit by @bencomp at some point. Thanks @bencomp !

bencomp added a commit to bencomp/dataverse that referenced this issue Jul 31, 2015
@bencomp
Improve log messages in DOIEZIDServiceBean IQSS#2277 IQSS#775
bb53bce 
Change INFO messages to WARNINGs when something went wrong;

use log message templates instead of concatenation, and the Throwable variant when
a Throwable is passed.

Improve formatting, add some javadoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sekmiller sekmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pdurbin @mheppler @bencomp @sekmiller @scolapasta