Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file upload limiter #2149

Closed
scolapasta opened this issue May 11, 2015 · 4 comments
Closed

Add file upload limiter #2149

scolapasta opened this issue May 11, 2015 · 4 comments
Assignees
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Type: Feature a feature request

Comments

@scolapasta
Copy link
Contributor

Add to the settings, if no setting, then lo limit.

Make sure it is used my primefaces upload, the API, and the dropbox upload.

@pdurbin
Copy link
Member

pdurbin commented May 12, 2015

@raprasad please note that the API already uses DataDepositApiMaxUploadInBytes per #1043 so please update the code and docs to use instead whatever new common (shared between the GUI and API) setting table key you come up with.

Here's how you'd test afterwards: http://guides.dataverse.org/en/latest/api/sword.html#add-files-to-a-dataset-with-a-zip-file

@raprasad
Copy link
Contributor

  • rename DataDepositApiMaxUploadInBytes to MaxFileUploadSizeInBytes
  • dropbox: use in DatasetPage.java handleDropBoxUpload
  • UI: sizeLimit="500000" invalidSizeMessage="File exceeds our limits. Please contact support."
  • update sword to use new settings name

@raprasad
Copy link
Contributor

If MaxFileUploadSizeInBytes is found in the settings table, use that number. If not, default to unlimited upload size.

Moving to QA

INSERT INTO setting values (':MaxFileUploadSizeInBytes', '100');

@raprasad raprasad assigned scolapasta and kcondon and unassigned raprasad and scolapasta May 13, 2015
@raprasad raprasad added Status: QA Type: Feature a feature request Component: Code Infrastructure formerly "Feature: Code Infrastructure" labels May 13, 2015
raprasad added a commit that referenced this issue May 13, 2015
@pdurbin pdurbin assigned raprasad and unassigned kcondon May 14, 2015
@scolapasta scolapasta assigned kcondon and unassigned raprasad May 14, 2015
@kcondon
Copy link
Contributor

kcondon commented May 20, 2015

OK, works, closing. Need to set this is prod to 10GB.

@kcondon kcondon closed this as completed May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Type: Feature a feature request
Projects
None yet
Development

No branches or pull requests

4 participants