Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming white spaces issue - dataverse alias #211

Closed
eaquigley opened this issue Jul 9, 2014 · 7 comments
Closed

Trimming white spaces issue - dataverse alias #211

eaquigley opened this issue Jul 9, 2014 · 7 comments
Labels
Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Type: Bug a defect Vote to Close: pdurbin

Comments

@eaquigley
Copy link
Contributor


Author Name: Elda Sotiri (@esotiri)
Original Redmine Issue: 3625, https://redmine.hmdc.harvard.edu/issues/3625
Original Date: 2014-03-04
Original Assignee: Xiangqing Yang


Entering a space at the end of the alias generates the following. I would expect to trim the white space at the end of alias, if any, and allow save action.

Found an illegal character(s). Valid characters are a-Z, 0-9, '', and '-'.Found an illegal character(s). Valid characters are a-Z, 0-9, '', and '-'.

@eaquigley eaquigley added this to the Dataverse 4.0: In Review milestone Jul 9, 2014
@joshhartigan
Copy link

This can probably be fixed in dataverse/src/main/java/edu/harvard/iq/dataverse/Dataverse.java around line 45, but I'm not sure how.

@eaquigley eaquigley assigned scolapasta and unassigned xyang02 Jul 15, 2014
@eaquigley eaquigley modified the milestones: Dataverse 4.0: Beta 3, Dataverse 4.0: In Review Jul 15, 2014
@scolapasta scolapasta modified the milestones: Beta 3 - Dataverse 4.0, Beta 4 - Dataverse 4.0, In Review - Dataverse 4.0 Aug 18, 2014
@scolapasta scolapasta modified the milestones: 4.01, In Review - Dataverse 4.0 Jan 6, 2015
@scolapasta scolapasta removed their assignment Jan 27, 2016
@mheppler mheppler added the Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... label Jan 28, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Feb 2, 2016

@eaquigley do you have a different expectation if someone tries to create a dataverse with a trailing space via API? Via API I'd expect to see an error message indicating which characters are valid, as reported above. However, as I believe @joshhartigan is suggesting, we could do the automatic trimming for both API and GUI.

@pdurbin
Copy link
Member

pdurbin commented Feb 2, 2016

@eaquigley oh, sorry, it was Elda who asserted an expectation above. I think @raprasad simply used your GitHub accounts to import this issue from Redmine.

@mheppler
Copy link
Contributor

mheppler commented Feb 2, 2016

Found a JSF-related, suggested solution on Stack Overflow.

@pdurbin
Copy link
Member

pdurbin commented Feb 5, 2016

In case it's of interest, I just wrote some tests of validation logic here: https://github.com/IQSS/dataverse/blob/ff7770b3cc24bcc88b868dcc1248c5d43ad39264/src/test/java/edu/harvard/iq/dataverse/authorization/providers/builtin/BuiltinUserTest.java (hasn't been merged yet, it's part of my pull request at #2919 ).

@pdurbin
Copy link
Member

pdurbin commented Jun 25, 2017

@joshhartigan are you still interested in working on this bug?

@pdurbin
Copy link
Member

pdurbin commented Jul 4, 2017

Come to think of it. I think the behavior described in the original report is what we want. We show an error when an invalid character is entered for a dataverse alias. Vote to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Type: Bug a defect Vote to Close: pdurbin
Projects
None yet
Development

No branches or pull requests

6 participants