-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Metadata - Producer and Distributor Logos URL + Logo URL Fields #207
Comments
Original Redmine Comment Propose removing both Logo URL and URL since these can easily go out of date (broken images and links) and do not seemingly offer any additional value for dataset discovery and reuse. Removed them from the general.tsv for now unless there is a strong opinion that these two elements should be re-added. |
Original Redmine Comment Merce suggested I get feedback from ODUM. Awaiting reply from ODUM and also consulted Libbie from Data-PASS / UCLA Dataverse. |
Original Redmine Comment See Issue #3900 |
Original Redmine Comment Tested on 5/6 Fields are removed and remaining fields working fine. Closing ticket |
Reopening after a discussion with @posixeleni |
@eaquigley & @mheppler We will need to review if and how we can properly support Distributor and Producer to have a URL and possibly Logo URL in the Citation Metadata Block. For the URL to the Distributor or Producer's website ideally we would have some way to check periodically to make sure the URLs are still working. For the long term this may not be sustainable since websites dont just change URLs but they come and go without any warning. For any URL that no longer worked would we just automatically remove them ? Or would we contact people to see if they can give us an active URL? |
My suggestion would be:
|
@mheppler @eaquigley |
Pushing to Beta 5 since we haven't reached a decision on this and it probably won't get into Beta 4. |
@mheppler can you make a decision based off the suggestions you listed above so we can get this working? thanks! |
Passing to @posixeleni to set values in displayFormat in db for these (per #1319). |
Per #1309 I have enabled this in the displayFormat field in the db. However, will need @mheppler to help me with the CSS styling to make these logos display in a uniform size. A more robust solution will be needed after 4.0 to look into implementing a feature for users to upload their distributor or producer logos using a form within the dataset. |
Added Bootstrap style class to metadata logo image HTML to fix width issues with really large images. [ref 47f6d6d] |
Added CSS styling to limit the height (40px) and width (180px) of logo images in the metadata fields, similarly to how it was done in 3.6. |
Works, closing |
Author Name: Mike Heppler (@mheppler)
Original Redmine Issue: 3621, https://redmine.hmdc.harvard.edu/issues/3621
Original Date: 2014-03-04
Original Assignee: Kevin Condon
Due to the 3.x way of saving logo URLs for the Contributor (was Distributor and Producer fields in 3.x), in the long term we can end up with broken image links when the image file link changes or the server that we're pointing to is down.
To avoid this in 4.0, test out removing Contributor Logo URL and URL from the UI to test out if users will miss it or not during beta. Will review after Beta to see if they should be added back. If added back we should consider allowing the data creator to upload a logo, via popup/image upload, that we will store the file in our database/server.
Related issue(s): #485
Redmine related issue(s): 3900
The text was updated successfully, but these errors were encountered: