Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Metadata - Producer and Distributor Logos URL + Logo URL Fields #207

Closed
eaquigley opened this issue Jul 9, 2014 · 30 comments
Closed
Assignees
Labels
Type: Feature a feature request

Comments

@eaquigley
Copy link
Contributor


Author Name: Mike Heppler (@mheppler)
Original Redmine Issue: 3621, https://redmine.hmdc.harvard.edu/issues/3621
Original Date: 2014-03-04
Original Assignee: Kevin Condon


Due to the 3.x way of saving logo URLs for the Contributor (was Distributor and Producer fields in 3.x), in the long term we can end up with broken image links when the image file link changes or the server that we're pointing to is down.

To avoid this in 4.0, test out removing Contributor Logo URL and URL from the UI to test out if users will miss it or not during beta. Will review after Beta to see if they should be added back. If added back we should consider allowing the data creator to upload a logo, via popup/image upload, that we will store the file in our database/server.


Related issue(s): #485
Redmine related issue(s): 3900


@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Eleni Castro (@posixeleni)
Original Date: 2014-04-07T15:15:53Z


Propose removing both Logo URL and URL since these can easily go out of date (broken images and links) and do not seemingly offer any additional value for dataset discovery and reuse. Removed them from the general.tsv for now unless there is a strong opinion that these two elements should be re-added.

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Eleni Castro (@posixeleni)
Original Date: 2014-04-21T05:51:08Z


Merce suggested I get feedback from ODUM. Awaiting reply from ODUM and also consulted Libbie from Data-PASS / UCLA Dataverse.

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Eleni Castro (@posixeleni)
Original Date: 2014-05-02T20:05:53Z


See Issue #3900

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Kevin Condon (@kcondon)
Original Date: 2014-05-06T15:47:17Z


Tested on 5/6

Fields are removed and remaining fields working fine.

Closing ticket

@eaquigley eaquigley added this to the Dataverse 4.0: Beta 1 milestone Jul 9, 2014
@eaquigley eaquigley reopened this Jul 14, 2014
@eaquigley eaquigley assigned eaquigley and unassigned kcondon Jul 14, 2014
@eaquigley
Copy link
Contributor Author

Reopening after a discussion with @posixeleni

@posixeleni
Copy link
Contributor

@eaquigley & @mheppler We will need to review if and how we can properly support Distributor and Producer to have a URL and possibly Logo URL in the Citation Metadata Block. For the URL to the Distributor or Producer's website ideally we would have some way to check periodically to make sure the URLs are still working. For the long term this may not be sustainable since websites dont just change URLs but they come and go without any warning. For any URL that no longer worked would we just automatically remove them ? Or would we contact people to see if they can give us an active URL?

@scolapasta scolapasta modified the milestones: Dataverse 4.0: In Review, Dataverse 4.0: Beta 1 Jul 14, 2014
@eaquigley eaquigley modified the milestones: Dataverse 4.0: Beta 3, Dataverse 4.0: In Review Jul 15, 2014
@mheppler
Copy link
Contributor

My suggestion would be:

  • Have a simple file upload for logos (http://www.primefaces.org/showcase/ui/file/upload/basic.xhtml)
  • For broken URLs, I would think we could run some site wide script that checks for broken URLs everywhere, and we can manually check that report to see what is bad.
  • Maybe we can have some templated email we manually send them asking them to update their metadata. I don't know how automated we need to/should have for this.
  • Here are some mentions because I'm told all the kids are doing it now: @eaquigley @posixeleni @pdurbin @scolapasta

@posixeleni
Copy link
Contributor

@mheppler @eaquigley
Sonia also mentioned to me that when we migrate the old logos and distributor name over we will need to change the ones that say IQSS Dataverse to dataverse.org or whatever the final name for our installation at Harvard will be.

@eaquigley
Copy link
Contributor Author

Pushing to Beta 5 since we haven't reached a decision on this and it probably won't get into Beta 4.

@eaquigley
Copy link
Contributor Author

@mheppler can you make a decision based off the suggestions you listed above so we can get this working? thanks!

@posixeleni posixeleni changed the title Dataset Metadata - Contributor URL + Logo URL Fields (was Producer and Distributor Logos) Dataset Metadata - Producer and Distributor Logos URL + Logo URL Fields Sep 29, 2014
@eaquigley eaquigley assigned mheppler and unassigned eaquigley Oct 15, 2014
@scolapasta scolapasta modified the milestones: Dataverse 4.0: Final, TEMP, Beta 12 - Dataverse 4.0 Jan 23, 2015
@scolapasta scolapasta assigned scolapasta and unassigned sekmiller Jan 23, 2015
@scolapasta
Copy link
Contributor

Passing to @posixeleni to set values in displayFormat in db for these (per #1319).

@scolapasta scolapasta assigned posixeleni and unassigned scolapasta Jan 30, 2015
@posixeleni
Copy link
Contributor

Per #1309 I have enabled this in the displayFormat field in the db. However, will need @mheppler to help me with the CSS styling to make these logos display in a uniform size. A more robust solution will be needed after 4.0 to look into implementing a feature for users to upload their distributor or producer logos using a form within the dataset.

@posixeleni posixeleni assigned mheppler and unassigned posixeleni Feb 4, 2015
@mheppler
Copy link
Contributor

mheppler commented Feb 5, 2015

Added Bootstrap style class to metadata logo image HTML to fix width issues with really large images. [ref 47f6d6d]

@scolapasta scolapasta modified the milestones: Beta 12 - Dataverse 4.0, In Review - Dataverse 4.0 Feb 6, 2015
@eaquigley eaquigley modified the milestones: Beta 13 - Dataverse 4.0, In Review - Dataverse 4.0 Feb 9, 2015
mheppler added a commit that referenced this issue Feb 17, 2015
@mheppler
Copy link
Contributor

Added CSS styling to limit the height (40px) and width (180px) of logo images in the metadata fields, similarly to how it was done in 3.6.

@kcondon
Copy link
Contributor

kcondon commented Feb 19, 2015

Works, closing

@kcondon kcondon closed this as completed Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature a feature request
Projects
None yet
Development

No branches or pull requests

7 participants