Test failed during vagrant up

[brainstorm]

Running edu.harvard.iq.dataverse.util.JsfHelperTest
enumValue
Jul 01, 2014 12:19:24 AM edu.harvard.iq.dataverse.util.JsfHelper enumValue
WARNING: Illegal value for enum edu.harvard.iq.dataverse.util.JsfHelperTest$TestEnum: 'THIS IS A BAD VALUE'

[pdurbin]

Technically, this is only a warning. Here's the full test output on my machine (Failures: 0):

Running edu.harvard.iq.dataverse.util.JsfHelperTest
enumValue
Jul 01, 2014 9:27:39 AM edu.harvard.iq.dataverse.util.JsfHelper enumValue
WARNING: Illegal value for enum edu.harvard.iq.dataverse.util.JsfHelperTest$TestEnum: 'THIS IS A BAD VALUE'
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec

I do agree it's a little confusing. @michbarsinai can you please take a look?

[pdurbin]

I spoke with @michbarsinai last week and he explained the printing of the warning is by design.

dataverse/src/main/java/edu/harvard/iq/dataverse/util/JsfHelper.java

Line 30 in 9e3d91d

logger.log(Level.WARNING, "Illegal value for enum {0}: ''{1}''", new Object[]{enmClass.getName(), param});

says

logger.log(Level.WARNING, "Illegal value for enum {0}: ''{1}''", new Object[]{enmClass.getName(), param});

The bad value is passed in at

dataverse/src/test/java/edu/harvard/iq/dataverse/util/JsfHelperTest.java

Line 53 in 7d2be85

assertEquals( TestEnum.Dolor, instance.enumValue("THIS IS A BAD VALUE", TestEnum.class, TestEnum.Dolor) );

as

assertEquals( TestEnum.Dolor, instance.enumValue("THIS IS A BAD VALUE", TestEnum.class, TestEnum.Dolor) );

In short, JsfHelper.java is supposed to log a warning.