-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index: Cannot see unpublished dv or ds if assigned proper view perms as IPGroup. #1513
Comments
Please retest. Be aware that IPGroups cannot have edit typer permissions, just read permissions. |
Waiting for #1380 to be fixed before we can test. |
Related, possibly a duplicate: #3105 |
Today @michbarsinai @scolapasta @kcondon and I discussed IP groups and I've been asked to try to reproduce this bug in the branch that pull request #3103 is based on. It's believed this is still a bug. |
I can easily reproduce this bug by giving an IP Group "admin" on an unpublished non-root dataverse, which should result in the "Guest" user being able to see a search card for the unpublished dataverse. Interestingly, the indexing seems fine. The unpublished dataverse in question says it's discoverable by the IP Group: The problem is at runtime we need a method in Dataverse to provide a list of all the IP Groups that a user (such as Guest) is a member of. This strongly reminds me of the |
Some initial progress in e6438c7 but a bit rushed. Ideally I'd add some API tests. |
This is working now. Phil, we can close this unless there is something more you want to do. |
I've directly assigned admin role/ view unpublished dv/ds to an ipgroup but still cannot see the unpublished dv/ds cards, though I can see the role assignment on the permissions page. I can go directly to the landing pages for both and the permissions page for both as a member of the ip group.
The text was updated successfully, but these errors were encountered: