Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse Subject: Remove from General Information Page, Have it be populated by dataset subjects #1452

Closed
eaquigley opened this issue Feb 13, 2015 · 4 comments
Assignees

Comments

@eaquigley
Copy link
Contributor

Per conversations with @mcrosas it makes more sense to have the subject of a dataverse be populated based off the subjects of the datasets contained within it. So we need to change the way it currently is in the application, including removing it as a selection from the General Information page for a dataverse.

@scolapasta
Copy link
Contributor

Decision for 4.0 - we will remove subject as required and also remove from the UI and API.

When editing a datset, it will populate its ancestors subject, but if you remove a subject, that will not remove (eventually yes, but is extra work, since you have to then look at all datasets).

mheppler added a commit that referenced this issue Feb 20, 2015
…e/edit form. Removed subject from the XHTML. Cleaned up the Metadata Fields section. [ref #1429, #1452, #1459]
@mheppler
Copy link
Contributor

Removed subject from the XHTML.

@scolapasta
Copy link
Contributor

Removed subject from JsonParser.

Added logic to Publish command (better than when editing) to populate subject for its ancestors. (note that if the dv(s) subjects changed, it also reindexes the dv(s)).

There will still be issues when you remove subjects (though technically an old version is still that subject - but we are not keeping that for the dataset), when you deaccession, and when you destroy.

@eaquigley
Copy link
Contributor Author

This is working the way it was described above. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants