URL: Pretty Faces URL with Dataverse Alias Bugs

[kcondon]

When you add/ display a dataverse on the featured dataverse area, the urls are the former, non pretty types.

[scolapasta]

Also in the header.

[scolapasta]

Assigned to @mheppler as these should be straightforward changes in the xhtml pages.

[mheppler]

I've found a few issues related to Pretty Faces URLs, not just the Featured Dataverse links. Here are my notes.

• The only place that is correctly applying Pretty Faces URLs are the "#{result.name} Dataverse" links in the dataverse cards on search-include-fragment, which uses "#{dataversePage}?alias=#{result.dataverseAlias}".
• That #{dataversePage} references a ui:param from Line 207: name="dataversePage" value="#{dataverseLinksStayOnPage == true ? '' : '/dataverse.xhtml' }" -- no idea what "dataverseLinksStayOnPage" means, and why it's there. Phil seems to think it's from the Data Related To Me view of search-include-fragment.
• Using: "/dataverse.xhtml?alias=#{dv.alias}" -- or some version of it -- doesn't work anywhere else, ie., dataset cards or the Featured Dataverse widget on dataverse.xhtml.
• The breadcrumbs on dataverse_header.html also do not have the Pretty Faces URL format.
• In total 7 pages use "dataverse.xhtml?id", which I found using a search in the project source are: DatasetPage.java, DataversePage.java, dataset.xhtml, dataverse.xhtml, dataverse_header.xhtml, dataverseuser.xhtml, widgets.js.

[mheppler]

The following pages all reference "dataverse.xhtml", and will need to be individually review, so as to consistently use the Pretty Faces URLs for dataverses, across the entire site.

• AdvancedSearch.java
• dataset.xhtml
• dataverse.xhtml
• dataverseuser.xhtml
• widgets.js
• themeAndWidgetsFragment.xhtml (doesn't use "dataverse.xhtml", but creates URLs that use id, which the widgets.js uses)

[mheppler]

AdvancedSearch.java, dataset.xhtml, dataverse.xhtml, dataverseuser.xhtml, widgets.js, themeAndWidgetsFragment.xhtml -- were all easy changes from id to alias. The rest will require review with a developer.

I am editing this list to be two parts. The above pages are easy, these next pages are more complicated.

• DatasetPage.java
• DataverseHeaderFragment.java

redirectPage = "dataverse.xhtml&alias=" + dataverseService.findRootDataverse().getAlias();

• DataversePage.java
• LoginPage.java

redirectPage = redirectPage + "&alias=" + dataverseService.findRootDataverse().getAlias();

• SearchIncludeFragment.java

dataverseRedirectPage = StringUtils.isBlank(dataverseRedirectPage) ? "dataverse.xhtml" : dataverseRedirectPage;
String optionalDataverseScope = "&alias=" + dataverse.getAlias();

return dataverseRedirectPage + "?faces-redirect=true&q=" + query + optionalDataverseScope;

• BuiltinUserPage.java

return "/dataverse.xhtml?alias=" + dataverseService.findRootDataverse().getAlias() + "faces-redirect=true;";

• PasswordResetPage.java

return "/dataverse.xhtml?alias=" + dataverseService.findRootDataverse().getAlias() + "faces-redirect=true";

• loginpage.xhtml

outcome="/dataverse.xhtml?alias=#{dataverseServiceBean.findRootDataverse().alias}"

Nothing needs to be done for:

• 404.xhtml ui:param name="loginRedirectPage" is OK having "dataverse.xhtml"
• 500.xhtml ui:param name="loginRedirectPage" is OK having "dataverse.xhtml"
• dataverse_header.xhtml ui:param name="dataversePage" are something that doesn't need to be address at this moment
• passwordreset.xhtml ui:param name="loginRedirectPage" is OK having "dataverse.xhtml"
• search-include-fragment.xhtml -- the New Dataverse link and ui:param name="dataversePage" are something that doesn't need to be address at this moment

Was not able to fix:

• Shib.java

[mheppler]

Passing to Gustavo to see if he can fix the use of "dataverse.xhtml" on Shib.java.

private final String homepage = "/dataverse.xhtml";

[scolapasta]

I'm actually going to pass this to @pdurbin, so he can add it how he would prefer (I think the easiest is to just remove the use of homepage and add dataverse.xhtml?alias=XXX in the places it's used).

@pdurbin, can you adjust this? the old way "dataverse.xhtml" is not good enough because it does not go through pretty faces. We have another issue #1519 to track how to do this, but for 4.0 we're just changing all those links to include the alias in the query string for the root (which you can get with the DataverseServieBean.findRootDataverse() method). Let me know if you have any questions.

[pdurbin]

As of b6b73f3 Shib users are redirected to the "pretty" URL for the homepage (http://localhost:8080/dataverse/root). There are three possible ways to end up there:

• When you log in with an existing Shib account
• When you log in as part of creating a Shib acount
• When you log in as part of converting to a Shib account (Account/Shibboleth: Converting from local to non-local #796)

In looking at this @scolapasta and I noticed that Shib users do not benefit from the fancy redirectPage logic developed in #869 for builtin users. We'll decided to open a new ticket at #1551 so that Shibboleth users get feature parity for this feature. For now, Shib users always end up at the homepage, but now it's the "pretty" URL. Passing to QA.

[posixeleni]

@kcondon showed me what I need to test for this.

[posixeleni]

I have tested different workflows indicated by @mheppler and @pdurbin (Shibb) above for getting to a Dataverse page. I'm seeing all pretty dataverse URLs. Including Widgets which takes you to a URL that looks like this: https://dvn-build.hmdc.harvard.edu/dataverse.xhtml?alias=sonia&q=Sonia

Closing.