Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a more graceful failure mode: TIFF images failure is not detected and a size-0 thumbnail is cached on s3 - and that results in the broken page view. #10352

Closed
sbarbosadataverse opened this issue Mar 1, 2024 · 2 comments · Fixed by #10509
Assignees
Labels
Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) Type: Bug a defect
Milestone

Comments

@sbarbosadataverse
Copy link

Normally when a thumbnail cannot be generated Dataverse detects the failure and then Jim's recently improved code marks the image as thumbnail-less. In this case, with these TIFF images for whatever reason the failure is not detected and a size-0 thumbnail is cached on s3 - and that's what results in the broken page view. (edit: even if there are somehow no exceptions thrown, we could detect that this was a failure by checking the size of the thumbnail produced)

reference
IQSS/dataverse.harvard.edu#250

@sbarbosadataverse
Copy link
Author

sbarbosadataverse commented Apr 3, 2024

We moved to prioritize but needs sizing

@sbarbosadataverse sbarbosadataverse moved this to SPRINT- NEEDS SIZING in IQSS Dataverse Project Apr 3, 2024
@juancorr
Copy link
Contributor

juancorr commented Apr 4, 2024

This problem also happens in traditional file systems, not only in S3.
The case #10317 refers to a traditional Linux file system.

@cmbz cmbz added the Size: 10 A percentage of a sprint. 7 hours. label Apr 10, 2024
@cmbz cmbz moved this from SPRINT- NEEDS SIZING to SPRINT READY in IQSS Dataverse Project Apr 10, 2024
@stevenwinship stevenwinship self-assigned this Apr 15, 2024
@stevenwinship stevenwinship moved this from SPRINT READY to In Progress 💻 in IQSS Dataverse Project Apr 15, 2024
@stevenwinship stevenwinship added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) and removed Size: 10 A percentage of a sprint. 7 hours. labels Apr 17, 2024
@sbarbosadataverse sbarbosadataverse added this to the 6.3 milestone Apr 24, 2024
@cmbz cmbz moved this to SPRINT READY in IQSS Dataverse Project Apr 24, 2024
landreev added a commit that referenced this issue Apr 30, 2024
…ro-size files are not left behind when rescaling fails; and to erase such when they are encountered for legacy files; renamed a method to better reflect what it does; and dropped TIF from the list of formats supported for custom logos. Nothing too serious.

it's still a mess, don't get me wrong. but should be ready to be merged, for now. #10352
landreev added a commit that referenced this issue Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) Type: Bug a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants