You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need a more graceful failure mode: TIFF images failure is not detected and a size-0 thumbnail is cached on s3 - and that results in the broken page view.
#10352
Normally when a thumbnail cannot be generated Dataverse detects the failure and then Jim's recently improved code marks the image as thumbnail-less. In this case, with these TIFF images for whatever reason the failure is not detected and a size-0 thumbnail is cached on s3 - and that's what results in the broken page view. (edit: even if there are somehow no exceptions thrown, we could detect that this was a failure by checking the size of the thumbnail produced)
…ro-size files are not left behind when rescaling fails; and to erase such when they are encountered for legacy files; renamed a method to better reflect what it does; and dropped TIF from the list of formats supported for custom logos. Nothing too serious.
it's still a mess, don't get me wrong. but should be ready to be merged, for now. #10352
Normally when a thumbnail cannot be generated Dataverse detects the failure and then Jim's recently improved code marks the image as thumbnail-less. In this case, with these TIFF images for whatever reason the failure is not detected and a size-0 thumbnail is cached on s3 - and that's what results in the broken page view. (edit: even if there are somehow no exceptions thrown, we could detect that this was a failure by checking the size of the thumbnail produced)
reference
IQSS/dataverse.harvard.edu#250
The text was updated successfully, but these errors were encountered: