Skip to content

Commit

Permalink
#5811 add comment for removing username column from built in user table
Browse files Browse the repository at this point in the history
  • Loading branch information
sekmiller committed May 3, 2019
1 parent 583b9f5 commit edf2abf
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ public void executeImpl(CommandContext ctxt) throws CommandException {
BuiltinUser bu = ctxt.builtinUsers().findByUserName(oldIdentifier);
au.setUserIdentifier(newIdentifier);

/*
5/3/2019
Related to 3575 and subsequent issues - we may decide to remove username from built in user as redundent
If so the code below will have to change, be careful around authenticated user lookup, could decide to leave as null if
AU lookup provider is built in.
*/

if (bu != null) {
bu.setUserName(newIdentifier);
AuthenticatedUserLookup aul = au.getAuthenticatedUserLookup();
Expand Down

0 comments on commit edf2abf

Please sign in to comment.