Merge pull request #5421 from IQSS/5419-less_autocomplete

add attribute to fields
IQSS · Jan 11, 2019 · c0f1655 · c0f1655
2 parents 36dea68 + 09b5065
commit c0f1655
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/main/webapp/dataverseuser.xhtml b/src/main/webapp/dataverseuser.xhtml
@@ -520,7 +520,7 @@
                                         </span>
                                     </label>
                                     <div class="col-sm-4">
-                                        <p:password id="currentPassword" label="#{bundle['user.currentPasswd']}" styleClass="form-control" value="#{DataverseUserPage.currentPassword}" />
+                                        <p:password id="currentPassword" label="#{bundle['user.currentPasswd']}" styleClass="form-control" value="#{DataverseUserPage.currentPassword}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                         <p:message for="currentPassword" display="text" />
                                     </div>
                                 </div>
@@ -540,7 +540,7 @@
                                         </div>
                                     </div>
                                     <div class="col-sm-4 col-sm-offset-3">
-                                        <p:password id="inputPassword" label="#{DataverseUserPage.editMode == 'CREATE' ? bundle['user.password'] : bundle['user.newPassword']}" styleClass="form-control" match="retypePassword" value="#{DataverseUserPage.inputPassword}" validator="#{DataverseUserPage.validateNewPassword}"  />
+                                        <p:password id="inputPassword" label="#{DataverseUserPage.editMode == 'CREATE' ? bundle['user.password'] : bundle['user.newPassword']}" styleClass="form-control" match="retypePassword" value="#{DataverseUserPage.inputPassword}" validator="#{DataverseUserPage.validateNewPassword}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                         <p:message for="inputPassword" display="text" />
                                     </div>
                                 </div>
@@ -552,7 +552,7 @@
                                         </span>
                                     </label>
                                     <div class="col-sm-4">
-                                        <p:password id="retypePassword" label="#{bundle['user.rePasswd']}" styleClass="form-control" value="#{DataverseUserPage.inputPassword}" />
+                                        <p:password id="retypePassword" label="#{bundle['user.rePasswd']}" styleClass="form-control" value="#{DataverseUserPage.inputPassword}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                         <p:message for="retypePassword" display="text" />
                                     </div>
                                 </div>

diff --git a/src/main/webapp/loginpage.xhtml b/src/main/webapp/loginpage.xhtml
@@ -67,7 +67,7 @@
                                             <div class="col-sm-8">
                                                 <h:inputText rendered="#{not fc.credential.secret}" value="#{fc.value}" id="credValue" styleClass="form-control"/>
                                                 <p:message rendered="#{not fc.credential.secret}" for="credValue" display="text"/>
-                                                <h:inputSecret rendered="#{fc.credential.secret}" value="#{fc.value}" id="sCredValue" styleClass="form-control"/>
+						<h:inputSecret rendered="#{fc.credential.secret}" value="#{fc.value}" id="sCredValue" styleClass="form-control" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                                 <p:message rendered="#{not fc.credential.secret}" for="sCredValue" display="text"/>
                                             </div>
                                         </div>

diff --git a/src/main/webapp/oauth2/convert.xhtml b/src/main/webapp/oauth2/convert.xhtml
@@ -45,7 +45,7 @@
                                     #{bundle['login.builtin.credential.password']}
                                 </label>
                                 <div class="col-sm-9">
-                                    <h:inputSecret value="#{OAuth2FirstLoginPage.password}" />
+					<h:inputSecret value="#{OAuth2FirstLoginPage.password}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                 </div>
                             </div>
 
@@ -83,4 +83,4 @@
             </ui:define>
         </ui:composition>
     </h:body>
-</html>
+</html>
diff --git a/src/main/webapp/passwordreset.xhtml b/src/main/webapp/passwordreset.xhtml
@@ -118,7 +118,7 @@
                                         </div>
                                     </div>
                                     <div class="col-sm-4 col-sm-offset-3">
-                                        <p:password id="inputPassword" label="#{bundle.passwd}" match="retypePassword" styleClass="form-control" value="#{PasswordResetPage.newPassword}" validator="#{PasswordResetPage.validateNewPassword}"/>
+					    <p:password id="inputPassword" label="#{bundle.passwd}" match="retypePassword" styleClass="form-control" value="#{PasswordResetPage.newPassword}" validator="#{PasswordResetPage.validateNewPassword}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
 					<p:message for="inputPassword" />
 					<p:focus for="inputPassword" />
                                     </div>
@@ -128,7 +128,7 @@
                                         #{bundle['passwdReset.rePasswd']} <span class="glyphicon glyphicon-asterisk text-danger" title="#{bundle.requiredField}"></span>
                                     </label>
                                     <div class="col-sm-4">
-                                        <p:password id="retypePassword" label="#{bundle['passwdReset.rePasswd']}" styleClass="form-control" value="#{PasswordResetPage.newPassword}"/>
+					    <p:password id="retypePassword" label="#{bundle['passwdReset.rePasswd']}" styleClass="form-control" value="#{PasswordResetPage.newPassword}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                         <p:message for="retypePassword" />
                                     </div>
                                 </div>

diff --git a/src/main/webapp/shib.xhtml b/src/main/webapp/shib.xhtml
@@ -108,7 +108,7 @@
                                     #{bundle['shib.currentDataversePassword']}
                                 </label>
                                 <div class="col-sm-3">
-                                    <p:password id="builtinPassword" styleClass="form-control" value="#{Shib.builtinPassword}"/>
+					<p:password id="builtinPassword" styleClass="form-control" value="#{Shib.builtinPassword}" autocomplete="off"/><!-- browsers will in general not respect autocomplete="foo", but scanners will still flag it as a potential problem -->
                                     <p class="help-block">
                                         <a href="passwordreset.xhtml">#{bundle['login.forgot.text']}</a>
                                     </p>
@@ -138,4 +138,4 @@
             </ui:define>
         </ui:composition>
     </h:body>
-</html>
+</html>