fix(rserve): avoid disfunctional JSF page when invalid Rserve port #7000

When an invalid port was set, which cannot be transformed to an integer,
the JSF page would kind of freeze: it leaves the user on the grayed out
"action" screen and if you click on it, shows upload page with no files,
so a silent error.

By defaulting to 6311 also for this case and logging an error, this
should improve the UX, but leave a hint for an admin in the logs.

doc/sphinx-guides/source/installation/config.rst

@@ -1587,7 +1587,7 @@ dataverse.rserve.port
 Port number for Rserve, used for tasks that require use of R (to ingest RData
 files and to save tabular data as RData frames).
 
-Defaults to ``6311``.
+Defaults to ``6311`` when not configured or no valid integer.
 
 Can also be set via *MicroProfile Config API* sources, e.g. the environment
 variable ``DATAVERSE_RSERVE_PORT``.

src/main/java/edu/harvard/iq/dataverse/ingest/tabulardata/impl/plugins/rdata/RDATAFileReader.java

@@ -438,7 +438,14 @@ public RDATAFileReader(TabularDataFileReaderSpi originator) {
     // ready to be overridden by a sysadmin. Every time a file would be read with this file reader,
     // a new reader will be created, reading from the cached config source settings with minimal overhead.
     this.RSERVE_HOST = JvmSettings.RSERVE_HOST.lookup();
-    this.RSERVE_PORT = JvmSettings.RSERVE_PORT.lookup(Integer.class);
+    int port;
+    try {
+      port = JvmSettings.RSERVE_PORT.lookup(Integer.class);
+    } catch (IllegalArgumentException e) {
+      LOG.log(Level.SEVERE, "Could not parse value for " + JvmSettings.RSERVE_PORT.getScopedKey() + ", defaulting to 6311", e);
+      port = 6311;
+    }
+    this.RSERVE_PORT = port;
     this.RSERVE_USER = JvmSettings.RSERVE_USER.lookup();
     this.RSERVE_PASSWORD = JvmSettings.RSERVE_PASSWORD.lookup();