Skip to content

Commit

Permalink
Private URL: add FIXME about the "just created" boolean #3174 #1012
Browse files Browse the repository at this point in the history
  • Loading branch information
pdurbin committed Jun 23, 2016
1 parent a8963d3 commit 2c80313
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/main/webapp/dataset.xhtml
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,8 @@
<div class="button-block">
<p:commandButton styleClass="btn btn-default" value="#{bundle['dataset.privateurl.createPrivateUrl']}" action="#{DatasetPage.createPrivateUrl()}" update="privateUrlPanel,:messagePanel" rendered="#{empty(DatasetPage.privateUrl)}" />
<p:commandButton styleClass="btn btn-default" value="#{bundle['dataset.privateurl.disablePrivateUrl']}" action="#{DatasetPage.setPrivateUrlJustCreatedToFalse()}" onclick="PF('privateUrlConfirmation').hide();PF('disablePrivateUrlConfirmation').show()" rendered="#{!empty(DatasetPage.privateUrl)}" update="privateUrlPanel"/>
<p:commandButton styleClass="btn btn-default" value="#{bundle.close}" onclick="PF('privateUrlConfirmation').hide();PF('blockDatasetForm').hide();" type="button" />
<!--FIXME: Why isn't DatasetPage.setPrivateUrlJustCreatedToFalse being called by this close button?!? Works fine on the "Disable Private URL" button above.-->
<p:commandButton styleClass="btn btn-default" value="#{bundle.close}" action="#{DatasetPage.setPrivateUrlJustCreatedToFalse()}" onclick="PF('privateUrlConfirmation').hide();PF('blockDatasetForm').hide();" type="button" update="privateUrlPanel"/>
</div>
</p:fragment>
<p:fragment id="privateUrlPanelCannotCreate" rendered="#{!DatasetPage.userCanCreatePrivateURL}">
Expand Down

0 comments on commit 2c80313

Please sign in to comment.