Fixed: type errors on DatasetMockData (stories) and DatasetMother (te…

…sts)
IQSS · Jun 1, 2023 · 513959f · 513959f
1 parent 0f8f95f
commit 513959f
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 28 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/stories/dataset/DatasetMockData.ts b/src/stories/dataset/DatasetMockData.ts
@@ -2,7 +2,8 @@ import {
   ANONYMIZED_FIELD_VALUE,
   DatasetStatus,
   DatasetVersion,
-  DatasetLabelSemanticMeaning
+  DatasetLabelSemanticMeaning,
+  DatasetLabelValue
 } from '../../dataset/domain/models/Dataset'
 import { MetadataBlockName } from '../../dataset/domain/models/Dataset'
 import { Dataset } from '../../dataset/domain/models/Dataset'
@@ -16,7 +17,7 @@ export const DatasetMockData = (props?: Partial<Dataset>, anonymized = false): D
   version: new DatasetVersion(1, 0, DatasetStatus.RELEASED),
   labels: [
     { value: 'Version 1.0', semanticMeaning: DatasetLabelSemanticMeaning.FILE },
-    { value: 'Draft', semanticMeaning: DatasetLabelSemanticMeaning.DATASET }
+    { value: DatasetLabelValue.DRAFT, semanticMeaning: DatasetLabelSemanticMeaning.DATASET }
   ],
   license: {
     name: 'CC0 1.0',

diff --git a/tests/component/dataset/domain/models/DatasetMother.ts b/tests/component/dataset/domain/models/DatasetMother.ts
@@ -4,7 +4,8 @@ import {
   Dataset,
   DatasetStatus,
   DatasetVersion,
-  DatasetLabelSemanticMeaning
+  DatasetLabelSemanticMeaning,
+  DatasetLabelValue
 } from '../../../../../src/dataset/domain/models/Dataset'
 import { MetadataBlockName } from '../../../../../src/dataset/domain/models/Dataset'
 
@@ -27,19 +28,19 @@ export class DatasetMother {
       },
       labels: [
         {
-          value: faker.lorem.word(),
+          value: DatasetLabelValue.IN_REVIEW,
           semanticMeaning: faker.helpers.arrayElement(Object.values(DatasetLabelSemanticMeaning))
         },
         {
-          value: faker.lorem.word(),
+          value: DatasetLabelValue.EMBARGOED,
           semanticMeaning: faker.helpers.arrayElement(Object.values(DatasetLabelSemanticMeaning))
         },
         {
-          value: faker.lorem.word(),
+          value: DatasetLabelValue.UNPUBLISHED,
           semanticMeaning: faker.helpers.arrayElement(Object.values(DatasetLabelSemanticMeaning))
         },
         {
-          value: faker.lorem.word(),
+          value: `Version ${faker.lorem.word()}`,
           semanticMeaning: faker.helpers.arrayElement(Object.values(DatasetLabelSemanticMeaning))
         }
       ],