Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71 - Add pending integration tests to the package #74

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Jun 27, 2023

What this PR does / why we need it:

This PR adds the pending integration tests for the different API repositories of te package.

PR #70, which adds the integration testing environment used for these changes, should be merged before this PR.

Which issue(s) this PR closes:

Special notes for your reviewer:

None

Suggestions on how to test this:

Follow PR #70 instructions

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@GPortas GPortas marked this pull request as ready for review June 27, 2023 14:47
@cmbz cmbz added the Size: 10 A percentage of a sprint. 7 hours. label Jul 5, 2023
@MellyGray MellyGray self-assigned this Jul 11, 2023
MellyGray
MellyGray previously approved these changes Jul 11, 2023
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@MellyGray MellyGray removed their assignment Jul 11, 2023
@kcondon kcondon dismissed MellyGray’s stale review July 12, 2023 13:16

The merge-base changed after approval.

@kcondon kcondon self-assigned this Jul 12, 2023
MellyGray
MellyGray previously approved these changes Jul 12, 2023
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after merge-base changed

@GPortas GPortas dismissed MellyGray’s stale review July 12, 2023 13:38

The merge-base changed after approval.

MellyGray
MellyGray previously approved these changes Jul 12, 2023
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved again

@GPortas GPortas dismissed MellyGray’s stale review July 12, 2023 13:43

The merge-base changed after approval.

@GPortas GPortas requested a review from MellyGray July 12, 2023 13:45
@GPortas GPortas self-assigned this Jul 12, 2023
@GPortas GPortas removed their assignment Jul 12, 2023
@kcondon kcondon merged commit a1e6709 into develop Jul 12, 2023
2 checks passed
@kcondon kcondon deleted the 71-pending-integration-tests branch July 12, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pending integration tests for existing use cases
4 participants