Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245 delete file use case #253

Merged
merged 7 commits into from
Feb 11, 2025
Merged

245 delete file use case #253

merged 7 commits into from
Feb 11, 2025

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:

Adds use case for deleting a file.

Which issue(s) this PR closes:

Suggestions on how to test this:

Visual code and check test actions.

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q1.6 Files Page: Files Edit Options FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) labels Feb 6, 2025
@ChengShi-1 ChengShi-1 self-assigned this Feb 6, 2025
@ChengShi-1 ChengShi-1 self-requested a review February 6, 2025 20:44
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! just small changes

@g-saracca
Copy link
Contributor Author

Thanks @ChengShi-1, changes applied 👍🏼

@g-saracca g-saracca removed their assignment Feb 10, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't mention it earlier. The test for deleting file in test/unit/files/FilesRepository.test.ts seems missing

@g-saracca g-saracca removed their assignment Feb 10, 2025
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Approve

@ChengShi-1 ChengShi-1 removed their assignment Feb 11, 2025
@ofahimIQSS ofahimIQSS self-assigned this Feb 11, 2025
@ofahimIQSS
Copy link
Contributor

tests are passing - merging PR

@ofahimIQSS ofahimIQSS merged commit 9d043ca into develop Feb 11, 2025
5 checks passed
@ofahimIQSS ofahimIQSS deleted the 245-delete-file-use-case branch February 11, 2025 21:18
@ofahimIQSS ofahimIQSS removed their assignment Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page SPA.Q1.6 Files Page: Files Edit Options
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Implement use case for deleting a file
3 participants