-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
245 delete file use case #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! just small changes
Thanks @ChengShi-1, changes applied 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't mention it earlier. The test for deleting file in test/unit/files/FilesRepository.test.ts
seems missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Approve
tests are passing - merging PR |
What this PR does / why we need it:
Adds use case for deleting a file.
Which issue(s) this PR closes:
Suggestions on how to test this:
Visual code and check test actions.
Is there a release notes update needed for this change?:
No
Additional documentation:
No