doc: remove all hard coded version numbers to simplify release #2786
Conversation
| @@ -18,9 +18,16 @@ include: [_includes] | |||
| # variables | |||
|
|
|||
| sidebar_tagline: Spoon | |||
| sidebar_version: version 7.0.0 | |||
There was a problem hiding this comment.
just for info, can't you define sidebar_version according to spoon_release?
There was a problem hiding this comment.
that is another option, but I prefer to simply get rid of sidebar_version
|
|
||
| # this is replaced at deployment time by job https://ci.inria.fr/sos/job/Website Deployer/ | ||
| # LATESTVERSION=`curl -s "http://search.maven.org/solrsearch/select?q=g:%22fr.inria.gforge.spoon%22+AND+a:%22spoon-core%22" | jq .response.docs[0].latestVersion` | ||
| # sed -i -e "s/^spoon_release: .*/spoon_release: $LATESTVERSION/" _config.yml |
There was a problem hiding this comment.
Is this command pushed somewhere?
There was a problem hiding this comment.
yes, in the Jenkins config, which is mirrored here https://github.com/SpoonLabs/spoon-ci-config
|
@GerardPaligot did before a script that automatically updates those version. I feel it is a better solution |
|
You're right, the problem is that this script is a bash monster that hasn't been executed and maintained for more than 4 years. |
|
I just looked a the script (that is not really a monster), it seems that it is pretty simple to maintain and only minor changes are required. |
|
Thanks for the link. Regardless of the script, I'm in favor of the simplification of this PR, on the ground that simpler means less error-prone today and in the future. |
|
That could be interesting to migrate all these old scripts from bash to a better and more maintainable language. You always use Maven to package your project, that could be interesting to migration to Gradle and create better scripts in Groovy or Kotlin for all these tasks that could be automatic. :) |
|
+100 for @GerardPaligot's comment. (good to see you Gérard :-) For the next release, I'm considering writing some Python scripts. |
|
With no other comments, ready for merge. |
monperrus
changed the title
|
ready for merge |
baby pr for #2779