Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nav menu dropdown menus #85

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fix nav menu dropdown menus #85

merged 2 commits into from
Feb 7, 2020

Conversation

joshdarby
Copy link

Changes

This pull request makes the following changes:

  • Adds nav class to the bottom-nav main menu so that the secondary menu dropdowns work

Why

For #35

Testing/Questions

Features that this PR affects:

  • Header menus

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

  1. Add a secondary menu item to a parent menu item for whatever menu is set to the Main Navigation Bottom location
  2. View on frontend and make sure that secondary menu dropdown works as expected

@joshdarby joshdarby added this to the Site-wide milestone Feb 7, 2020
@joshdarby joshdarby requested a review from benlk February 7, 2020 14:27
@joshdarby joshdarby self-assigned this Feb 7, 2020
@benlk
Copy link
Collaborator

benlk commented Feb 7, 2020

I'll merge and deploy this, but we need to make the hitboxes on the carets in the mobile nav wider:

Screen Shot 2020-02-07 at 10 30 13

@benlk benlk merged commit a62fd9d into master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlk benlk Awaiting requested review from benlk

Assignees

@joshdarby joshdarby

Labels
None yet
Projects
None yet
Milestone
Site-wide
Development

Successfully merging this pull request may close these issues.
2 participants
@joshdarby @benlk