Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job board #76

Merged
merged 5 commits into from
Jan 31, 2020
Merged

Job board #76

merged 5 commits into from
Jan 31, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Jan 31, 2020

Changes

This pull request makes the following changes:

  • Adds function that sets custom partial for the jobs cpt archive
  • Adds a function that updates the jobs cpt archive title
  • Adds styling for jobs cpt archive
  • Adds single job template and partial and relevant styling

Archive desktop:
screencapture-ipbs-test-2020-01-31-11_59_30

Archive mobile:
screencapture-ipbs-test-2020-01-31-11_59_52

Single job:
screencapture-ipbs-test-2020-01-31-12_00_12

Why

For #75

Testing/Questions

Features that this PR affects:

  • Job archive and single job template

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Do we want to do anything else with the single job template?

Steps to test this PR:

  1. Go to dashboard -> cpt ui -> edit post types -> jobs -> settings -> has archive = true
  2. Import the new job location and job organization acf fields
[
    {
        "key": "group_5e332e8e414f0",
        "title": "Jobs",
        "fields": [
            {
                "key": "field_5e332e9111a31",
                "label": "Location",
                "name": "location",
                "type": "text",
                "instructions": "",
                "required": 0,
                "conditional_logic": 0,
                "wrapper": {
                    "width": "",
                    "class": "",
                    "id": ""
                },
                "default_value": "",
                "placeholder": "",
                "prepend": "",
                "append": "",
                "maxlength": "",
                "readonly": 0,
                "disabled": 0
            },
            {
                "key": "field_5e332ea411a32",
                "label": "Organization",
                "name": "organization",
                "type": "text",
                "instructions": "",
                "required": 1,
                "conditional_logic": 0,
                "wrapper": {
                    "width": "",
                    "class": "",
                    "id": ""
                },
                "default_value": "",
                "placeholder": "",
                "prepend": "",
                "append": "",
                "maxlength": "",
                "readonly": 0,
                "disabled": 0
            }
        ],
        "location": [
            [
                {
                    "param": "post_type",
                    "operator": "==",
                    "value": "job"
                }
            ]
        ],
        "menu_order": 0,
        "position": "normal",
        "style": "default",
        "label_placement": "top",
        "instruction_placement": "label",
        "hide_on_screen": "",
        "active": 1,
        "description": ""
    }
]
  1. View https://ipbs.test/?post_type=job and make sure it looks ok on desktop and mobile
  2. Click on a single job post and make sure it looks ok

@joshdarby joshdarby added this to the Interior Page milestone Jan 31, 2020
@joshdarby joshdarby requested a review from benlk January 31, 2020 17:04
@joshdarby joshdarby self-assigned this Jan 31, 2020
Copy link
Collaborator

@benlk benlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-01-31 at 14 06 05

A minor thing that does not prevent merging: we may want to limit the width of the .entry-content column to something like 70ch or 35em, to make the job description more readable.

Beyond that, this looks good and is mergeable.


$args = apply_filters( 'largo_content_partial_arguments', $args, get_queried_object() );

extract( $args );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use extract(), but Largo does rely upon it in these templates. ☹️

@joshdarby joshdarby merged commit ba1ea7a into master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants