Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize homepage, with menu #51

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Initialize homepage, with menu #51

merged 1 commit into from
Jan 22, 2020

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 22, 2020

Changes

This pull request makes the following changes:

  • adds homepage layout and rough template
  • adds homepage LESS and CSS
  • adds blank less/variables.less so that the homepage template can reference that
  • registers "Homepage Quick Links" menu location for output on homepage top, since that's shown in the wireframes
  • does not match any designs, yet, because the designs are not yet approved

Why

For #40.

Testing/Questions

Features that this PR affects:

  • Homepage choice in Appearance > Theme Options > Layout
  • New menu option in Appearance > Menus > Locations

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Is there any other boilerplate code that needs to be added before we start on design work?

Steps to test this PR:

  1. In Settings > Reading, set "Your Homepage Displays" to "Latest Posts".
  2. Activate the homepage layout
  3. Create a new menu to fit the "Homepage Quick Links" location and populate it
  4. Add some widgets to the "Homepage Bottom" widget area
  5. View the homepage: are the widgets present? Are the links in the menu present?

@benlk benlk added this to the Homepage milestone Jan 22, 2020
@benlk benlk requested a review from joshdarby January 22, 2020 00:02
@benlk benlk self-assigned this Jan 22, 2020
@joshdarby
Copy link

@benlk This looks good, but it might be worth noting that we need to set the homepage to your latest posts in settings -> reading since their prod site now has the homepage set to a static page.

@benlk
Copy link
Collaborator Author

benlk commented Jan 22, 2020

I'll add that to the go-live documentation as well.

@benlk benlk merged commit aafe507 into master Jan 22, 2020
@benlk benlk mentioned this pull request Jan 22, 2020
1 task
@benlk benlk deleted the 40-homepage-template branch January 22, 2020 16:07
@benlk benlk mentioned this pull request Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants