Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraints.txt make goal #662

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Add constraints.txt make goal #662

merged 1 commit into from
Aug 18, 2022

Conversation

matentzn
Copy link
Contributor

No description provided.

@matentzn matentzn marked this pull request as ready for review August 18, 2022 12:30
@matentzn matentzn requested a review from gouttegd August 18, 2022 12:30
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but it’s up to whoever is running the command to make sure the Python version they’re using is the same major Python version as the one provided within the ODK. If you’re running it with an older Python, you could end up being stuck with old versions of packages (as has happened here with oaklib); if you’re running it with a newer version, you could end up with packages that won’t work within the ODK…

I didn’t want to do that, but I think the best way to make sure we are always running the correct version of Python is to run this command from within the ODK container. I’ll work on that.

@@ -125,7 +125,7 @@ log to determine if any modifications have been made?
## General SOP for ODK release and publication

* Put the `master` branch in the state we want for release (i.e. merge any approved PR that we want included in that release, etc.).
* Update the [constraits.txt file](https://github.com/INCATools/ontology-development-kit/pull/476#issuecomment-924050937)
* Update the [constraits.txt file](https://github.com/INCATools/ontology-development-kit/pull/476#issuecomment-924050937), with `make constraints.txt`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: constraits.txt -> constraints.txt

nxontology==0.4.1
oaklib==0.1.17
oaklib==0.1.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very old version of oaklib. You are probably running the command with an old version of Python (Python 3.8). Recent versions of oaklib (1.4+) require Python 3.9.

@gouttegd gouttegd merged commit b4f45b6 into master Aug 18, 2022
@matentzn matentzn deleted the update-constraints branch December 5, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants