Build odkfull:dev from odklite:dev.
#661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the main Dockerfile to allow to specify a different `odklite` version to build `odkfull` from, instead of always building from `odklite:latest`. Update the main Makefile so that the `build-dev` and `publish-multiarch-dev` rules build the `odkfull:dev` image from `odklite:dev`, so that the resulting image does contain all the latest changes as intended. closes #659
matentzn
approved these changes
Aug 17, 2022
|
Awesome, thank you @gouttegd! |
|
It would have been more awesome if I had caught that before merging PR #653, but better late than never I guess. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the main Dockerfile to allow to specify a different
odkliteversion to buildodkfullfrom, instead of always building fromodklite:latest.Update the main Makefile so that the
build-devandpublish-multiarch-devrules build theodkfull:devimage fromodklite:dev, so that the resulting image does contain all the latest changes as intended.closes #659