Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First fixes 131: components, $(MAKE) and reports #570

Merged
merged 20 commits into from
May 3, 2022
Merged

First fixes 131: components, $(MAKE) and reports #570

merged 20 commits into from
May 3, 2022

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 7, 2022 •
edited
Loading

  • Added shortcut make commands for recreating components: recreate-components and recreate-%
  • Generated ROBOT reports now consider the imports by default
  • Run internal make and $(MAKE) to ensure that parameters are propagated correctly (issue)
    Mirror goal is only run when mirrors have been downloaded

matentzn added 4 commits March 7, 2022 12:32
@matentzn
Replacing make calls by $(MAKE)
c1be053 
- fixes #554
@matentzn
Adding phony goals for components
0986683
@matentzn
Reports should use graph by default
6da0b2c
@matentzn
Make sure mirror goal exists before copying it
c27f909 
This ensures that if mirror generation is skipped for some reason, no attempt is made to copy anything.
@matentzn matentzn changed the title First fixes 131 First fixes 131: components, $(MAKE) and reports Mar 7, 2022
@matentzn matentzn requested a review from gouttegd May 2, 2022 09:45
@matentzn
Copy link
Contributor Author

matentzn commented May 2, 2022

@gouttegd sorry I bundled a few things into one PR while I was working on many problems at once.. Would like to merge this to return to a more.. atomic form of PRs.. :) Would you mind taking a look?

gouttegd
gouttegd requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo the fact that js2cli should be declared in requirements.txt.lite and in requirements.txt.

@matentzn matentzn requested a review from gouttegd May 3, 2022 10:52
@matentzn
Copy link
Contributor Author

matentzn commented May 3, 2022

Else is fine, can I merge?

@matentzn matentzn merged commit 05aa89e into master May 3, 2022
@matentzn matentzn deleted the first-fixes-131 branch May 3, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouttegd gouttegd gouttegd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matentzn @gouttegd