Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ionic to latest and remove ionic cli pin #291

Merged
merged 8 commits into from
May 16, 2017
Merged

Update Ionic to latest and remove ionic cli pin #291

merged 8 commits into from
May 16, 2017

Conversation

mleu
Copy link
Member

@mleu mleu commented May 15, 2017 •
edited
Loading

A local coverage report looks as good as ever.
Coveralls reports lower coverage on all src/mocks/response/ classes on super(new ResponseOptions ... In my opinion we can live with it. Opened #292 to investigate reason.

This should (hopefully ;-) close #190 and close #278.

Before testing this please delete node_modules and do

npm remove -g ionic
npm install -g ionic
npm install

Ionic services don't directly support environment variables anymore, I have opened ionic-team/ionic-cli#2293 to ask for it again.

mleu added 3 commits May 15, 2017 23:47
@mleu
update packages to ionic 3 and angular 4
0624602
@mleu
fix webpack warnings
e3a3e05 
driftyco/ionic-unit-testing-example/#34
@mleu
update to ionic-cli v3
20f8610 
use ionic cli provided thru dev depencies
fix script as ionic package now does a build before uploading and has different output
@mleu mleu changed the title Update to Ionic to latest and remove ionic cli pin Update Ionic to latest and remove ionic cli pin May 15, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 93.927% when pulling d574d53 on ionic3-v2 into 3ed4555 on master.

@mleu
do a login before ionic package on CI
6c377bf 
new ionic cli v3 does not support environment variables anymore
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 96.221% when pulling 6c377bf on ionic3-v2 into 3ed4555 on master.

@mleu mleu mentioned this pull request May 16, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 96.221% when pulling 6edbf57 on ionic3-v2 into 3ed4555 on master.

sandrozbinden
sandrozbinden approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@sandrozbinden sandrozbinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juhuuu we are on ionic 3. Thanks for the effort

@sandrozbinden sandrozbinden merged commit 5a2afe6 into master May 16, 2017
@sandrozbinden sandrozbinden deleted the ionic3-v2 branch May 16, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrozbinden sandrozbinden sandrozbinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: update ionic cli to v3 update ionic to 3.0
3 participants
@mleu @coveralls @sandrozbinden