Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for transmission #18

Merged
merged 17 commits into from
Nov 20, 2024
Merged

Fixes for transmission #18

merged 17 commits into from
Nov 20, 2024

Conversation

ka-sarthak
Copy link
Collaborator

@ka-sarthak ka-sarthak commented Nov 11, 2024

  • Uses an updated version of transmission (from AreaA repo) plugin.

  • Overwrites the definition of results and settings rather than using m_copy

  • Adds an IKZ-specific parser for .asc that uses IKZ-specific ELN

  • Extends write_transmission_data method to include specialized behavior

  • Adds IKZCategory to the specialized schema

  • Adds tests for parsing of transmission files

  • It allows a more modular way to specializing the schemas for IKZ. write_transmission_data has been simplified by abstracting out composition of the sub-sections into a separate method compose_subsections. In a specialized ELN class, one has to simply override compose_subsections to use IKZ specific results and settings. Then, write_transmission_data can also be extended to add more data into the transmission section.

  • Add specialized write_transmission_data and compose_subsections methods

@ka-sarthak ka-sarthak force-pushed the fixes-for-transmission branch 3 times, most recently from 4b1365a to 7e0f2ad Compare November 12, 2024 14:17
@ka-sarthak ka-sarthak force-pushed the fixes-for-transmission branch from 62aea7d to 980d3ec Compare November 13, 2024 00:36
@ka-sarthak ka-sarthak requested review from aalbino2, budschi and hampusnasstrom and removed request for budschi November 13, 2024 14:23
@ka-sarthak ka-sarthak self-assigned this Nov 19, 2024
@ka-sarthak
Copy link
Collaborator Author

This is connected to the changes made here FAIRmat-NFDI/AreaA-data_modeling_and_schemas#206

Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but looks good

@ka-sarthak ka-sarthak merged commit 7f9c172 into main Nov 20, 2024
@ka-sarthak ka-sarthak deleted the fixes-for-transmission branch November 20, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants