-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for transmission #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b1365a
to
7e0f2ad
Compare
62aea7d
to
980d3ec
Compare
This is connected to the changes made here FAIRmat-NFDI/AreaA-data_modeling_and_schemas#206 |
5 tasks
hampusnasstrom
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested but looks good
aalbino2
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses an updated version of
transmission
(from AreaA repo) plugin.Overwrites the definition of results and settings rather than using
m_copy
Adds an IKZ-specific parser for
.asc
that uses IKZ-specific ELNExtends
write_transmission_data
method to include specialized behaviorAdds
IKZCategory
to the specialized schemaAdds tests for parsing of transmission files
It allows a more modular way to specializing the schemas for IKZ.write_transmission_data
has been simplified by abstracting out composition of the sub-sections into a separate methodcompose_subsections
. In a specialized ELN class, one has to simply overridecompose_subsections
to use IKZ specific results and settings. Then,write_transmission_data
can also be extended to add more data into the transmission section.Add specializedwrite_transmission_data
andcompose_subsections
methods