Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

202502review #186

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

202502review #186

wants to merge 17 commits into from

Conversation

lukeaduncan
Copy link
Contributor

Issues are addressed in individual commits.

📑 Description

This is to address most of the issues from the final round of review. Actor updates are still pending.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • I have selected a committee co-chair to review the PR

ℹ Additional Information

@lukeaduncan
Correct path in publication-request. Fixes #168.
e215f52
@lukeaduncan
Added 130 to index. Fixes #169.
730b452
@lukeaduncan
Expanded text for changes in 4.0. Fixes #170.
ff4cffa
@lukeaduncan
Replaced FederatedDeployment.png. Fixes #179.
bdff164
@lukeaduncan
Added diagram and updated text on use case 7 for feed transaction. Fixes
e6891f4 
 #169.
@lukeaduncan
Previous commit fixes #172.
438325b
@lukeaduncan
Clarified usage of batch and transaction. Fixes #175.
b250fd4
@lukeaduncan
Removed partof that was now duplicated in SHALL and SHOULD. Fixes #180.
d2f994e
@lukeaduncan
Removed mention of HTTP and HTTPS as redundant. Fixes #181.
1f23c7a
@lukeaduncan
Added content in security considerations to mention access controls a…
c940079 
…nd IUA. Also added text under expected actions related to duplication checks. Fixes #174.
@lukeaduncan
Updated text on supported resources to include the Feed supplier. Fixes
9844234 
#176.
@lukeaduncan
Fixed typo in Feed consumer actor for capability statements. Fixes #177.
d3edf92
@lukeaduncan
Simplified reference to TLS in security considerations. Fixes #178.
67b2fdc
@lukeaduncan
Moved Z.6 reference to the correct response messages. Fixes #182.
7b8e830
@lukeaduncan
Removed reference to the LocationDistance that doesn't apply to these…
b941862 
… actors. Fixes #183.
@lukeaduncan
Fixed text for link to response sections. Fixes #184.
281aab2
@lukeaduncan
Added in audit event for the bundle processing and a note to use it i…
2bded39 
…n addition to the individual events for each entry in the bundle. Fixes #173.
JohnMoehrke
JohnMoehrke approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@JohnMoehrke JohnMoehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMoehrke JohnMoehrke JohnMoehrke approved these changes

@slagesse-epic slagesse-epic Awaiting requested review from slagesse-epic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeaduncan @JohnMoehrke