Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGVF-1890-model-file-set-summary #1065

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Conversation

jenjou
Copy link
Contributor

@jenjou jenjou commented Sep 3, 2024

No description provided.

@jenjou jenjou force-pushed the IGVF-1890-model-file-set-summary branch from 1721732 to 9348097 Compare September 16, 2024 16:17
@shengchd shengchd self-requested a review September 16, 2024 19:18

def test_summary(testapp, model_set_no_input):
res = testapp.get(model_set_no_input['@id'])
assert res.json.get('summary') == 'predictive model v0.0.1 neural network targeting genes'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to change the word 'targeting' to 'predicting'?

shengchd
shengchd previously approved these changes Sep 16, 2024
Copy link
Contributor

@shengchd shengchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, I just have a suggestion on wording.

shengchd
shengchd previously approved these changes Sep 16, 2024
@ottojolanki ottojolanki merged commit 6b20f8f into dev Sep 17, 2024
9 checks passed
@ottojolanki ottojolanki deleted the IGVF-1890-model-file-set-summary branch September 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants