-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGVF-1890-model-file-set-summary #1065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenjou
force-pushed
the
IGVF-1890-model-file-set-summary
branch
from
September 16, 2024 16:17
1721732
to
9348097
Compare
shengchd
reviewed
Sep 16, 2024
|
||
def test_summary(testapp, model_set_no_input): | ||
res = testapp.get(model_set_no_input['@id']) | ||
assert res.json.get('summary') == 'predictive model v0.0.1 neural network targeting genes' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make more sense to change the word 'targeting' to 'predicting'?
shengchd
previously approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, I just have a suggestion on wording.
shengchd
previously approved these changes
Sep 16, 2024
jenjou
force-pushed
the
IGVF-1890-model-file-set-summary
branch
from
September 17, 2024 22:16
df8e532
to
c4a8537
Compare
shengchd
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.