Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not assume admin privileges on keystone #138

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

alvarolopez
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@41c0821). Learn more about missing BASE report.

Files with missing lines Patch % Lines
caso/extract/manager.py 47.05% 9 Missing ⚠️
caso/extract/openstack/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #138   +/-   ##
=========================================
  Coverage          ?   51.48%           
=========================================
  Files             ?       23           
  Lines             ?     1142           
  Branches          ?      165           
=========================================
  Hits              ?      588           
  Misses            ?      542           
  Partials          ?       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Avoid issues when running cASO with a low privileges account that cannot
list all projects and scope the tokens to the projects that are to be
accounted. This allows to run cASO and generate records for non-admin
users.

Closes #124
Copy link

sonarcloud bot commented Sep 27, 2024

@alvarolopez alvarolopez merged commit 6daa0de into master Sep 28, 2024
15 checks passed
@alvarolopez alvarolopez deleted the no-admin branch September 28, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants