Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial packaging intro #14

Merged
merged 20 commits into from
Aug 16, 2024

Conversation

lsetiawan
Copy link
Collaborator

@lsetiawan lsetiawan commented Jul 27, 2024

This PR add initial packaging intro tutorial.

(uwhackweek/schedule-2024#23)

@lsetiawan lsetiawan added the preview Create a website preview label Jul 27, 2024
Copy link
Contributor

github-actions bot commented Jul 27, 2024

@lsetiawan lsetiawan marked this pull request as ready for review August 8, 2024 22:33
@lsetiawan lsetiawan requested a review from RomiP August 8, 2024 22:34
@JessicaS11
Copy link
Member

@lsetiawan Is this ready for review?

@lsetiawan
Copy link
Collaborator Author

Is this ready for review?

@JessicaS11 You are welcome to review anytime. Open to any changes. I just finished making the full first draft. Hope it all makes sense 😄 Thanks!

Copy link
Member

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @lsetiawan ! I love the analogies, puns, organization and build up to https://www.pyopensci.org. It's rendering really well and I think it's great as-is, so I'm going to approve it, but I did leave a few comments on the intro material that came to mind as I went through it.

@lsetiawan
Copy link
Collaborator Author

I'm really grateful for your review @scottyhq! This is by no means a complete final. I'll update some more later this week. I'm glad to hear that the structure is good and you enjoyed the content 😄

@JessicaS11
Copy link
Member

@lsetiawan @RomiP Just noticed this tutorial doesn't show up on the tutorials page. Could you add it to https://github.com/ICESAT-2HackWeek/website-2024/blob/main/book/tutorials/index.md?

@lsetiawan
Copy link
Collaborator Author

@scottyhq I'm really grateful for your thorough review and thoughtful suggestions, I've made adjustments based on your suggestions. 😄

@JessicaS11 I've added this tutorial to the index. Hopefully that works.

With all that being said, I'm going to merge this for now, so we have something and I'll edit some more for the next few days.

@lsetiawan lsetiawan merged commit 3958f02 into ICESAT-2HackWeek:main Aug 16, 2024
4 checks passed
@lsetiawan lsetiawan deleted the pack_intro branch August 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Create a website preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants