Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1461: test for bridge sampling #1473

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

arrjon
Copy link
Contributor

@arrjon arrjon commented Sep 20, 2024

Fixes issue #1461

The test failed too often, since the value which we compared to was unreliable. Now changed from harmonic mean sampling to laplace approximation.

@arrjon arrjon self-assigned this Sep 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (f92fc8b) to head (9321ba9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1473      +/-   ##
===========================================
- Coverage    82.86%   82.82%   -0.04%     
===========================================
  Files          163      163              
  Lines        13760    13760              
===========================================
- Hits         11402    11397       -5     
- Misses        2358     2363       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arrjon arrjon added CI sampling Related to sampling labels Sep 20, 2024
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, only failed 9 out of 100 times. Perhaps just for safety raise the flaky to 3 reruns? But probably not necessary.

@PaulJonasJost PaulJonasJost merged commit ab61c4a into develop Sep 26, 2024
18 checks passed
@PaulJonasJost PaulJonasJost deleted the fix_1461_test_bridge_sampling branch September 26, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI sampling Related to sampling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants